Page MenuHomePhabricator
Differential D11665

[web] convert updating thread activity `lastThreadNavigatedTo` on web to use sqlite
ClosedPublic
Actions

Authored by will on Mon, Apr 15, 2:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 7:18 PM
Unknown Object (File)
Sat, Apr 27, 3:08 AM
Unknown Object (File)
Fri, Apr 26, 11:52 AM
Unknown Object (File)
Thu, Apr 25, 5:26 PM
Unknown Object (File)
Tue, Apr 23, 5:30 PM
Unknown Object (File)
Tue, Apr 23, 4:30 PM
Unknown Object (File)
Sun, Apr 21, 3:46 PM
Unknown Object (File)
Sun, Apr 21, 8:33 AM
View All 15 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
ginsu
Commits
rCOMMd82518d49a1b: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use…
Summary

Currently, the redux reducer just updates redux persist thread activity. Realized I was missing this when doing final testing

The non-sqlite implementation can be found at https://phab.comm.dev/D9404

Depends on D11617

Test Plan

Navigated to several different threads on web app and corresponding thread activity entries were found in web database

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Mon, Apr 15, 2:28 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Apr 15, 2:28 PM
will edited the summary of this revision. (Show Details)Mon, Apr 15, 2:29 PM
will added a parent revision: D11617: [native][web] Start processing thread activity store with sqlite operations.
will added 1 blocking reviewer(s): atul.
will added a child revision: D11618: [native][web] Read thread activity entries from SQLite on app start.
Harbormaster completed remote builds in B28230: Diff 39134.Mon, Apr 15, 2:45 PM
will requested review of this revision.Mon, Apr 15, 2:45 PM
atul accepted this revision.Tue, Apr 16, 11:35 AM
atul added inline comments.
web/redux/redux-setup.js
505–508 ↗(On Diff #39134)

I'd maybe pull this out and above, but whatever you prefer works.

This revision is now accepted and ready to land.Tue, Apr 16, 11:35 AM
will updated this revision to Diff 39173.Tue, Apr 16, 10:18 PM

review feedback

Harbormaster completed remote builds in B28258: Diff 39173.Tue, Apr 16, 10:34 PM
Closed by commit rCOMMd82518d49a1b: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use… (authored by will). · Explain WhyFri, Apr 19, 1:08 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMd82518d49a1b: [web] convert updating thread activity `lastThreadNavigatedTo` on web to use….

Revision Contents
Changeset List

PathSize
web/
redux/
35 lines

Diff 39324

View Options

web/redux/redux-setup.js

Loading...