Page MenuHomePhabricator
Differential D11614

[sqlite] Implement C++ code for native to get sqlite thread activity entries
ClosedPublic
Actions

Authored by will on Apr 9 2024, 10:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 1:17 AM
Unknown Object (File)
Sat, Mar 15, 5:34 AM
Unknown Object (File)
Mon, Mar 10, 7:35 AM
Unknown Object (File)
Feb 27 2025, 5:17 PM
Unknown Object (File)
Feb 26 2025, 5:56 PM
Unknown Object (File)
Feb 16 2025, 3:58 AM
Unknown Object (File)
Feb 16 2025, 3:58 AM
Unknown Object (File)
Feb 16 2025, 3:58 AM
View All 71 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM9567929ea151: [sqlite] Implement C++ code for native to get sqlite thread activity entries
Summary

This implements C++ code to allow native to get sqlite thread activity entries

Depends on D11584

Test Plan

Ran the following code and console logged the thread activity store successfully:

let data = await commCoreModule.getClientDBStore();
console.log(data.threadActivityEntries);

await commCoreModule.processThreadActivityStoreOperations([
  {
    type: 'replace_thread_activity_entry',
    payload: {
      id: 'test_A_id',
      threadActivityStoreEntry: JSON.stringify({
        lastNavigatedTo: 1,
        lastPruned: 2,
      }),
    },
  },
  {
    type: 'remove_all_thread_activity_entries',
  },
  {
    type: 'replace_thread_activity_entry',
    payload: {
      id: 'test_B_id',
      threadActivityStoreEntry: JSON.stringify({
        lastNavigatedTo: 3,
        lastPruned: 4,
      }),
    },
  },
  {
    type: 'replace_thread_activity_entry',
    payload: {
      id: 'test_C_id',
      threadActivityStoreEntry: JSON.stringify({
        lastNavigatedTo: 5,
        lastPruned: 6,
      }),
    },
  },
  {
    type: 'remove_thread_activity_entries',
    payload: {
      ids: ['test_B_id'],
    },
  },
]);

data = await commCoreModule.getClientDBStore();
console.log(data.threadActivityEntries);

Screenshot 2024-04-10 at 1.55.43 AM.png (156×826 px, 22 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Apr 9 2024, 10:53 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 9 2024, 10:53 PM
will edited the test plan for this revision. (Show Details)Apr 9 2024, 10:54 PM
will edited the test plan for this revision. (Show Details)
will edited the summary of this revision. (Show Details)
will added a parent revision: D11584: [sqlite/native] Make C++ thread activity sqlite ops available to native.
will added a child revision: D11615: [sqlite] Implement processing thread activity on web worker.Apr 9 2024, 10:59 PM
Harbormaster completed remote builds in B28117: Diff 38973.Apr 9 2024, 11:10 PM
will requested review of this revision.Apr 9 2024, 11:10 PM
kamil accepted this revision.Apr 10 2024, 5:40 AM
This revision is now accepted and ready to land.Apr 10 2024, 5:40 AM
will updated this revision to Diff 39166.Apr 16 2024, 8:58 PM
will edited the summary of this revision. (Show Details)

thread_activity_store_entry => threadActivityStoreEntry

Harbormaster completed remote builds in B28255: Diff 39166.Apr 16 2024, 9:14 PM
Closed by commit rCOMM9567929ea151: [sqlite] Implement C++ code for native to get sqlite thread activity entries (authored by will). · Explain WhyApr 19 2024, 1:08 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM9567929ea151: [sqlite] Implement C++ code for native to get sqlite thread activity entries.

Revision Contents
Changeset List

PathSize
lib/
types/
2 lines
native/
cpp/
CommonCpp/
NativeModules/
16 lines
PersistentStorageUtilities/
DataStores/
18 lines
web/
shared-worker/
worker/
1 line

Diff 39320

View Options

lib/types/store-ops-types.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js'; import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMAddMembersOperation } from '../../types/dm-ops.js'; import type { DMAddMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { type RawMessageInfo } from '../../types/message-types.js';
import type { AddMembersMessageData } from '../../types/messages/add-members.js'; import type { AddMembersMessageData } from '../../types/messages/add-members.js';
import { import { minimallyEncodeMemberInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
minimallyEncodeMemberInfo,
type ThickRawThreadInfo,
} from '../../types/minimally-encoded-thread-permissions-types.js';
import { joinThreadSubscription } from '../../types/subscription-types.js'; import { joinThreadSubscription } from '../../types/subscription-types.js';
import type { ThickMemberInfo } from '../../types/thread-types.js'; import type { ThickMemberInfo } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { values } from '../../utils/objects.js'; import { values } from '../../utils/objects.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
import { roleIsDefaultRole, userIsMember } from '../thread-utils.js'; import { roleIsDefaultRole, userIsMember } from '../thread-utils.js';
export type AddMembersResult = {
rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>,
threadInfo: ?ThickRawThreadInfo,
};
function createAddNewMembersMessageDataFromDMOperation( function createAddNewMembersMessageDataFromDMOperation(
dmOperation: DMAddMembersOperation, dmOperation: DMAddMembersOperation,
): AddMembersMessageData { ): AddMembersMessageData {
const { editorID, time, addedUserIDs, threadID } = dmOperation; const { editorID, time, addedUserIDs, threadID } = dmOperation;
return { return {
type: messageTypes.ADD_MEMBERS, type: messageTypes.ADD_MEMBERS,
threadID, threadID,
creatorID: editorID, creatorID: editorID,
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js'; import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMAddMembersOperation } from '../../types/dm-ops.js'; import type { DMAddMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { type RawMessageInfo } from '../../types/message-types.js';
import type { AddMembersMessageData } from '../../types/messages/add-members.js'; import type { AddMembersMessageData } from '../../types/messages/add-members.js';
import { import { minimallyEncodeMemberInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
minimallyEncodeMemberInfo,
type ThickRawThreadInfo,
} from '../../types/minimally-encoded-thread-permissions-types.js';
import { joinThreadSubscription } from '../../types/subscription-types.js'; import { joinThreadSubscription } from '../../types/subscription-types.js';
import type { ThickMemberInfo } from '../../types/thread-types.js'; import type { ThickMemberInfo } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { values } from '../../utils/objects.js'; import { values } from '../../utils/objects.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
import { roleIsDefaultRole, userIsMember } from '../thread-utils.js'; import { roleIsDefaultRole, userIsMember } from '../thread-utils.js';
export type AddMembersResult = {
rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>,
threadInfo: ?ThickRawThreadInfo,
};
function createAddNewMembersMessageDataFromDMOperation( function createAddNewMembersMessageDataFromDMOperation(
dmOperation: DMAddMembersOperation, dmOperation: DMAddMembersOperation,
): AddMembersMessageData { ): AddMembersMessageData {
const { editorID, time, addedUserIDs, threadID } = dmOperation; const { editorID, time, addedUserIDs, threadID } = dmOperation;
return { return {
type: messageTypes.ADD_MEMBERS, type: messageTypes.ADD_MEMBERS,
threadID, threadID,
creatorID: editorID, creatorID: editorID,
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/ThreadActivityStore.cpp

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js'; import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMAddMembersOperation } from '../../types/dm-ops.js'; import type { DMAddMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { type RawMessageInfo } from '../../types/message-types.js';
import type { AddMembersMessageData } from '../../types/messages/add-members.js'; import type { AddMembersMessageData } from '../../types/messages/add-members.js';
import { import { minimallyEncodeMemberInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
minimallyEncodeMemberInfo,
type ThickRawThreadInfo,
} from '../../types/minimally-encoded-thread-permissions-types.js';
import { joinThreadSubscription } from '../../types/subscription-types.js'; import { joinThreadSubscription } from '../../types/subscription-types.js';
import type { ThickMemberInfo } from '../../types/thread-types.js'; import type { ThickMemberInfo } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { values } from '../../utils/objects.js'; import { values } from '../../utils/objects.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
import { roleIsDefaultRole, userIsMember } from '../thread-utils.js'; import { roleIsDefaultRole, userIsMember } from '../thread-utils.js';
export type AddMembersResult = {
rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>,
threadInfo: ?ThickRawThreadInfo,
};
function createAddNewMembersMessageDataFromDMOperation( function createAddNewMembersMessageDataFromDMOperation(
dmOperation: DMAddMembersOperation, dmOperation: DMAddMembersOperation,
): AddMembersMessageData { ): AddMembersMessageData {
const { editorID, time, addedUserIDs, threadID } = dmOperation; const { editorID, time, addedUserIDs, threadID } = dmOperation;
return { return {
type: messageTypes.ADD_MEMBERS, type: messageTypes.ADD_MEMBERS,
threadID, threadID,
creatorID: editorID, creatorID: editorID,
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines
View Options

web/shared-worker/worker/process-operations.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import uuid from 'uuid'; import uuid from 'uuid';
import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js'; import { createRoleAndPermissionForThickThreads } from './create-thread-spec.js';
import type { import type {
DMOperationSpec, DMOperationSpec,
ProcessDMOperationUtilities, ProcessDMOperationUtilities,
} from './dm-op-spec.js'; } from './dm-op-spec.js';
import type { DMAddMembersOperation } from '../../types/dm-ops.js'; import type { DMAddMembersOperation } from '../../types/dm-ops.js';
import { messageTypes } from '../../types/message-types-enum.js'; import { messageTypes } from '../../types/message-types-enum.js';
import { type RawMessageInfo } from '../../types/message-types.js';
import type { AddMembersMessageData } from '../../types/messages/add-members.js'; import type { AddMembersMessageData } from '../../types/messages/add-members.js';
import { import { minimallyEncodeMemberInfo } from '../../types/minimally-encoded-thread-permissions-types.js';
minimallyEncodeMemberInfo,
type ThickRawThreadInfo,
} from '../../types/minimally-encoded-thread-permissions-types.js';
import { joinThreadSubscription } from '../../types/subscription-types.js'; import { joinThreadSubscription } from '../../types/subscription-types.js';
import type { ThickMemberInfo } from '../../types/thread-types.js'; import type { ThickMemberInfo } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { ClientUpdateInfo } from '../../types/update-types.js';
import { values } from '../../utils/objects.js'; import { values } from '../../utils/objects.js';
import { rawMessageInfoFromMessageData } from '../message-utils.js'; import { rawMessageInfoFromMessageData } from '../message-utils.js';
import { roleIsDefaultRole, userIsMember } from '../thread-utils.js'; import { roleIsDefaultRole, userIsMember } from '../thread-utils.js';
export type AddMembersResult = {
rawMessageInfos: Array<RawMessageInfo>,
updateInfos: Array<ClientUpdateInfo>,
threadInfo: ?ThickRawThreadInfo,
};
function createAddNewMembersMessageDataFromDMOperation( function createAddNewMembersMessageDataFromDMOperation(
dmOperation: DMAddMembersOperation, dmOperation: DMAddMembersOperation,
): AddMembersMessageData { ): AddMembersMessageData {
const { editorID, time, addedUserIDs, threadID } = dmOperation; const { editorID, time, addedUserIDs, threadID } = dmOperation;
return { return {
type: messageTypes.ADD_MEMBERS, type: messageTypes.ADD_MEMBERS,
threadID, threadID,
creatorID: editorID, creatorID: editorID,
▲ Show 20 Lines • Show All 115 Lines • Show Last 20 Lines