[sqlite] Implement C++ methods for thread activity
ClosedPublic
Actions

Authored by will on Apr 8 2024, 1:33 PM.

Details

Reviewers

kamil
atul
ginsu

Commits

rCOMM7aa6f6dc604f: [sqlite] Implement C++ methods for thread activity

Summary

This implements the sqlite operations for thread activity in C++

Depends on D11579

Test Plan

flow check. Ran the thread-activity-queries.test.js successfully

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Apr 8 2024, 1:33 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 8 2024, 1:33 PM

will added a child revision: D11584: [sqlite/native] Make C++ thread activity sqlite ops available to native.Apr 8 2024, 1:51 PM

rebase

Harbormaster completed remote builds in B28053: Diff 38903.Apr 8 2024, 2:05 PM

Harbormaster completed remote builds in B28059: Diff 38909.Apr 8 2024, 2:39 PM

will requested review of this revision.Apr 8 2024, 2:39 PM

Looks good, thanks for adding unit tests... definitely improves confidence in changes

This revision is now accepted and ready to land.Apr 8 2024, 5:30 PM

Closed by commit rCOMM7aa6f6dc604f: [sqlite] Implement C++ methods for thread activity. · Explain WhyApr 19 2024, 8:08 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM7aa6f6dc604f: [sqlite] Implement C++ methods for thread activity.

Revision Contents
Changeset List

Path

Size

lib/

ops/

thread-activity-store-ops.js

5 lines

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

8 lines

SQLiteQueryExecutor.h

7 lines

SQLiteQueryExecutor.cpp

45 lines

entities/

ThreadActivityEntry.h

24 lines

web/

cpp/

SQLiteQueryExecutorBindings.cpp

15 lines

shared-worker/

_generated/

comm_query_executor.wasm

queries/

thread-activity-queries.test.js

117 lines

types/

sqlite-query-executor.js

8 lines

Diff 39318

View Options

lib/ops/thread-activity-store-ops.js

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/ThreadActivityEntry.h

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

View Options

web/shared-worker/_generated/comm_query_executor.wasm

View Options

web/shared-worker/queries/thread-activity-queries.test.js

View Options

web/shared-worker/types/sqlite-query-executor.js

[sqlite] Implement C++ methods for thread activityClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 39318

lib/ops/thread-activity-store-ops.js

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/ThreadActivityEntry.h

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/thread-activity-queries.test.js

web/shared-worker/types/sqlite-query-executor.js

[sqlite] Implement C++ methods for thread activity
ClosedPublic
Actions

Revision Contents
Changeset List