Page MenuHomePhabricator
Differential D11578

[lib] refactor thread activity reducer to use sqlite operations
ClosedPublic
Actions

Authored by will on Apr 8 2024, 6:24 AM.
Tags
None
Referenced Files
F6060038: D11578.id38907.diff
Sun, Apr 20, 8:55 AM
Unknown Object (File)
Sun, Apr 20, 4:04 AM
Unknown Object (File)
Sat, Apr 19, 8:55 PM
Unknown Object (File)
Sat, Apr 19, 11:41 AM
Unknown Object (File)
Sat, Apr 19, 10:56 AM
Unknown Object (File)
Sat, Apr 19, 4:56 AM
Unknown Object (File)
Thu, Apr 17, 10:01 PM
Unknown Object (File)
Mar 20 2025, 7:52 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
atul
ginsu
Commits
rCOMM68fc96783930: [lib] refactor thread activity reducer to use sqlite operations
Summary

Refactor the thread activity reducer to use sqlite operations

Depends on D11576

Test Plan

Passing existing thread activity reducer tests. Actual sqlite operations are tested later in stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Apr 8 2024, 6:24 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 8 2024, 6:24 AM
will edited the summary of this revision. (Show Details)Apr 8 2024, 6:25 AM
will added a parent revision: D11576: [native/sqlite] Create thread activity table in sqlite.
will added a child revision: D11579: [lib] return ops from thread activity reducer.Apr 8 2024, 6:27 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 8 2024, 6:28 AM
Harbormaster failed remote builds in B28048: Diff 38898!
will updated this revision to Diff 38907.Apr 8 2024, 6:55 AM

rebase

Harbormaster completed remote builds in B28057: Diff 38907.Apr 8 2024, 7:30 AM
will requested review of this revision.Apr 8 2024, 7:30 AM
atul accepted this revision.Apr 8 2024, 10:28 AM
This revision is now accepted and ready to land.Apr 8 2024, 10:28 AM
will updated this revision to Diff 39024.Apr 10 2024, 2:03 PM

Consider case of optional fields

Harbormaster completed remote builds in B28150: Diff 39024.Apr 10 2024, 2:19 PM
will updated this revision to Diff 39121.Apr 15 2024, 6:27 AM

rebase

Harbormaster completed remote builds in B28222: Diff 39121.Apr 15 2024, 6:42 AM
Closed by commit rCOMM68fc96783930: [lib] refactor thread activity reducer to use sqlite operations (authored by will). · Explain WhyApr 19 2024, 12:32 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM68fc96783930: [lib] refactor thread activity reducer to use sqlite operations.

Revision Contents
Changeset List

PathSize
lib/
reducers/
78 lines

Diff 39314

View Options

lib/reducers/thread-activity-reducer.js

#pragma once #pragma once
#include <string> #include <string>
#include <vector> #include <vector>
namespace comm { namespace comm {
class BackupOperationsExecutor { class BackupOperationsExecutor {
public: public:
static void createMainCompaction(std::string backupID, size_t futureID); static void createMainCompaction(std::string backupID, size_t futureID);
static void restoreFromMainCompaction( static void restoreFromMainCompaction(
std::string mainCompactionPath, std::string mainCompactionPath,
std::string mainCompactionEncryptionKey, std::string mainCompactionEncryptionKey,
size_t futureID); size_t futureID);
static void restoreFromBackupLog(const std::vector<std::uint8_t> &backupLog); static void restoreFromBackupLog(
const std::vector<std::uint8_t> &backupLog,
size_t futureID);
}; };
} // namespace comm } // namespace comm