Page MenuHomePhabricator

[lib][landing][web] Update patch versions of Rainbowkit and Wagmi
ClosedPublic

Authored by ashoat on Oct 6 2023, 12:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 8:56 AM
Unknown Object (File)
Fri, Nov 1, 3:47 AM
Unknown Object (File)
Sat, Oct 12, 3:17 AM
Unknown Object (File)
Thu, Oct 10, 11:58 PM
Unknown Object (File)
Oct 5 2024, 6:01 PM
Unknown Object (File)
Oct 5 2024, 5:55 PM
Unknown Object (File)
Oct 5 2024, 5:50 PM
Unknown Object (File)
Oct 2 2024, 10:48 AM
Subscribers

Details

Summary

These updates have no breaking changes. I was testing this during investigation of ENG-5152... it turned out not to be necessary, but I figured I'd diff it up anyways since it's good to have recent package versions.

Test Plan

I deployed these patch versions to my staging keyserver at comm.domains, and then ran a version of the mobile app pointed there. I made sure that SIWE still worked with Rainbow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat requested review of this revision.Oct 6 2023, 1:07 PM
atul accepted this revision.EditedOct 6 2023, 1:10 PM

IIRC we were using some CSS selectors from dist that might need to be updated?

EDIT:
These guys:

188d48.png (682×3 px, 191 KB)

Maybe they've remained stable if nothing appeared off during testing?

This revision is now accepted and ready to land.Oct 6 2023, 1:10 PM

Good call out, thanks for linking them.

Maybe they've remained stable if nothing appeared off during testing?

Yeah, I think so. I checked node_modules/@rainbow-me/rainbowkit/dist/components/index.css and those two CSS selector class names still appeared in there, so I suspect it hasn't changed. RainbowKit's GitHub Releases page also lists each patch in each version bump, and I confirmed none of them touch that CSS file.