Page MenuHomePhabricator

[lib][landing][web] Update patch versions of Rainbowkit and Wagmi
ClosedPublic

Authored by ashoat on Oct 6 2023, 12:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 1:41 PM
Unknown Object (File)
Fri, Nov 29, 9:46 AM
Unknown Object (File)
Mon, Nov 25, 11:24 AM
Unknown Object (File)
Tue, Nov 19, 10:38 PM
Unknown Object (File)
Tue, Nov 12, 9:34 AM
Unknown Object (File)
Mon, Nov 11, 4:45 AM
Unknown Object (File)
Sun, Nov 10, 7:23 AM
Unknown Object (File)
Thu, Nov 7, 2:32 PM
Subscribers

Details

Summary

These updates have no breaking changes. I was testing this during investigation of ENG-5152... it turned out not to be necessary, but I figured I'd diff it up anyways since it's good to have recent package versions.

Test Plan

I deployed these patch versions to my staging keyserver at comm.domains, and then ran a version of the mobile app pointed there. I made sure that SIWE still worked with Rainbow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested review of this revision.Oct 6 2023, 1:07 PM
atul accepted this revision.EditedOct 6 2023, 1:10 PM

IIRC we were using some CSS selectors from dist that might need to be updated?

EDIT:
These guys:

188d48.png (682×3 px, 191 KB)

Maybe they've remained stable if nothing appeared off during testing?

This revision is now accepted and ready to land.Oct 6 2023, 1:10 PM

Good call out, thanks for linking them.

Maybe they've remained stable if nothing appeared off during testing?

Yeah, I think so. I checked node_modules/@rainbow-me/rainbowkit/dist/components/index.css and those two CSS selector class names still appeared in there, so I suspect it hasn't changed. RainbowKit's GitHub Releases page also lists each patch in each version bump, and I confirmed none of them touch that CSS file.