Paths

Table of Contentst

-
lib/reducers/
-
reducers/
-
thread-activity-reducer.js

[lib] Handle `messageStorePruneActionType` in `reduceThreadActivity`
ClosedPublic
Actions

Authored by atul on Oct 6 2023, 1:22 PM.

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMM37ed3d6636fe: [lib] Handle `messageStorePruneActionType` in `reduceThreadActivity`

Summary

We want to upsert lastPruned for threadIDs included in messageStorePruneActionType payload in threadActivityStore.

Depends on D9404

Test Plan

Modify pruning code to run every minute
Observe that lastPruned inside threadActivityStore gets set as expected on messageStorePruneActionType

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Oct 6 2023, 1:22 PM

Herald added a subscriber: will. · View Herald TranscriptOct 6 2023, 1:22 PM

atul published this revision for review.Oct 6 2023, 1:23 PM

Harbormaster completed remote builds in B23071: Diff 31763.Oct 6 2023, 1:41 PM

ashoat accepted this revision.Oct 9 2023, 2:01 PM

This revision is now accepted and ready to land.Oct 9 2023, 2:01 PM

rebase and land

This revision was landed with ongoing or failed builds.Oct 9 2023, 2:16 PM

Closed by commit rCOMM37ed3d6636fe: [lib] Handle `messageStorePruneActionType` in `reduceThreadActivity` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM37ed3d6636fe: [lib] Handle `messageStorePruneActionType` in `reduceThreadActivity`.

Harbormaster completed remote builds in B23132: Diff 31839.Oct 9 2023, 2:34 PM

Revision Contents
Changeset List

Path

Size

lib/

reducers/

thread-activity-reducer.js

14 lines

Diff 31839

View Options

lib/reducers/thread-activity-reducer.js

// @flow

import * as React from 'react';

import { FlatList, Platform } from 'react-native';

import { SafeAreaView } from 'react-native-safe-area-context';

import { useSelector } from 'react-redux';

import {

childThreadInfos,

communityThreadSelector,

} from 'lib/selectors/thread-selectors';

import { threadIsChannel } from 'lib/shared/thread-utils';

import {

import { type ThreadInfo, communitySubthreads } from 'lib/types/thread-types';

createRecursiveDrawerItemsData,

appendSuffix,

} from 'lib/utils/drawer-utils.react';

import { useNavigateToThread } from '../chat/message-list-types';

import { useStyles } from '../themes/colors';

import type { TextStyle } from '../types/styles';

import CommunityDrawerItemCommunity from './community-drawer-item-cummunity.react';

const maxDepth = 2;

const safeAreaEdges = Platform.select({

ios: ['top'],

default: ['top', 'bottom'],

});

Show All 10 Lines

function CommunityDrawerContent(): React.Node {

const navigateToThread = useNavigateToThread();

const childThreadInfosMap = useSelector(childThreadInfos);

const setOpenCommunnityOrClose = React.useCallback((index: string) => {

setOpenCommunity(open => (open === index ? null : index));

}, []);

const renderItem = React.useCallback(

({ item }) => {

const itemData = {

threadInfo: item.threadInfo,

itemChildren: item.itemChildren,

labelStyle: item.labelStyle,

hasSubchannelsButton: item.subchannelsButton,

};

return (

<CommunityDrawerItemCommunity

key={item.key}

key={item.threadInfo.id}

itemData={itemData}

itemData={item}

toggleExpanded={setOpenCommunnityOrClose}

expanded={itemData.threadInfo.id === openCommunity}

expanded={item.threadInfo.id === openCommunity}

navigateToThread={navigateToThread}

);

michalUnsubmitted

Not Done

}, []);

const renderItem = React.useCallback(

- ({ item }) => {

- return (

+ ({ item }) => (

<CommunityDrawerItemCommunity

key={item.threadInfo.id}

itemData={item}

toggleExpanded={setOpenCommunnityOrClose}

expanded={item.threadInfo.id === openCommunity}

navigateToThread={navigateToThread}

- );

- },

+ ),

[navigateToThread, openCommunity, setOpenCommunnityOrClose],

This now can be simplified.

michal: This now can be simplified.

[navigateToThread, openCommunity, setOpenCommunnityOrClose],

);

const labelStylesObj = useStyles(labelUnboundStyles);

const labelStyles = React.useMemo(

() => [

labelStylesObj.level0Label,

labelStylesObj.level1Label,

labelStylesObj.level2Label,

[labelStylesObj],

);

const drawerItemsData = React.useMemo(

() =>

createRecursiveDrawerItemsData(

childThreadInfosMap,

communitiesSuffixed,

labelStyles,

maxDepth,

[childThreadInfosMap, communitiesSuffixed, labelStyles],

);

return (

</SafeAreaView>

);

}

function createRecursiveDrawerItemsData(

childThreadInfosMap: { +[id: string]: $ReadOnlyArray<ThreadInfo> },

communities: $ReadOnlyArray<ThreadInfo>,

labelStyles: $ReadOnlyArray<TextStyle>,

) {

const result = communities.map(community => ({

key: community.id,

threadInfo: community,

itemChildren: [],

labelStyle: labelStyles[0],

subchannelsButton: false,

}));

let queue = result.map(item => [item, 0]);

for (let i = 0; i < queue.length; i++) {

const [item, lvl] = queue[i];

const itemChildThreadInfos = childThreadInfosMap[item.threadInfo.id] ?? [];

if (lvl < maxDepth) {

item.itemChildren = itemChildThreadInfos

.filter(childItem => communitySubthreads.includes(childItem.type))

.map(childItem => ({

threadInfo: childItem,

itemChildren: [],

labelStyle: labelStyles[Math.min(lvl + 1, labelStyles.length - 1)],

hasSubchannelsButton:

lvl + 1 === maxDepth &&

threadHasSubchannels(childItem, childThreadInfosMap),

}));

queue = queue.concat(

item.itemChildren.map(childItem => [childItem, lvl + 1]),

);

}

return result;

}

function threadHasSubchannels(

threadInfo: ThreadInfo,

childThreadInfosMap: { +[id: string]: $ReadOnlyArray<ThreadInfo> },

) {

if (!childThreadInfosMap[threadInfo.id]?.length) {

return false;

}

return childThreadInfosMap[threadInfo.id].some(thread =>

threadIsChannel(thread),

);

}

function appendSuffix(chats: $ReadOnlyArray<ThreadInfo>): ThreadInfo[] {

const result = [];

const names = new Map<string, number>();

for (const chat of chats) {

let name = chat.uiName;

const numberOfOccurrences = names.get(name);

names.set(name, (numberOfOccurrences ?? 0) + 1);

if (numberOfOccurrences) {

name = `${name} (${numberOfOccurrences.toString()})`;

}

result.push({ ...chat, uiName: name });

}

return result;

}

const unboundStyles = {

drawerContent: {

flex: 1,

paddingRight: 8,

paddingTop: 8,

backgroundColor: 'drawerBackgroud',

};

Show All 26 Lines

[lib] Handle `messageStorePruneActionType` in `reduceThreadActivity`ClosedPublicActions