Page MenuHomePhabricator

[landing] Update useMonitorForWalletConnectModal for new WalletConnect modal
ClosedPublic

Authored by ashoat on Oct 9 2023, 1:12 PM.
Tags
None
Referenced Files
F3329220: D9435.id31863.diff
Wed, Nov 20, 4:39 PM
F3329214: D9435.id31823.diff
Wed, Nov 20, 4:39 PM
F3329088: D9435.id.diff
Wed, Nov 20, 4:37 PM
F3328888: D9435.diff
Wed, Nov 20, 4:18 PM
Unknown Object (File)
Oct 19 2024, 4:20 AM
Unknown Object (File)
Oct 19 2024, 4:20 AM
Unknown Object (File)
Oct 19 2024, 4:19 AM
Unknown Object (File)
Oct 19 2024, 4:01 AM
Subscribers

Details

Summary

The WalletConnect modal has been updated, and now the HTML is slightly different.

Depends on D9434

Test Plan

I tested the WalletConnect modal:

  1. Tested iOS and Android physical devices
  2. Tested in a public staging environment (comm.domains)
  3. Tested the QR code scan feature on web
  4. Tested expanding to see "All wallets"
  5. Tested selecting a wallet (Rainbow)
  6. Tested searching for a wallet by typing a query

Some videos of the testing can be seen in the final diff in the stack.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable