While working on ENG-5182, I noticed that we prevent subchannel creation to be announcement channels. From an initial investigation, it looks like it's been disabled since D5211. An error is thrown when attempting to create a new subchannel with the announcement setting because it fails the input validation.
Details
Details
Ran yarn workspace lib test (to make sure thread-responders.test.js still worked, and more importantly manually tested creating both an open announcement subchannel and a secret announcement subchannel. The permissions like I mentioned are kind of weird though since non-members of the new secret subchannel can discover it in the navigation drawer, so I'll make it part of my overall permissions fixes for ENG-5182.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
web/modals/threads/create/compose-subchannel-modal.react.js | ||
---|---|---|
102–106 ↗ | (On Diff #31998) | Do we have anything equivalent on native? Or is it not possible to create an announcement channel on native yet? |