Page MenuHomePhabricator

[web] Introduce codegen-identity-grpc script
ClosedPublic

Authored by ashoat on Oct 13 2023, 1:00 PM.
Tags
None
Referenced Files
F3327378: D9491.diff
Wed, Nov 20, 9:26 AM
Unknown Object (File)
Mon, Oct 28, 2:10 PM
Unknown Object (File)
Mon, Oct 28, 2:10 PM
Unknown Object (File)
Mon, Oct 28, 2:10 PM
Unknown Object (File)
Mon, Oct 28, 2:10 PM
Unknown Object (File)
Mon, Oct 28, 2:08 PM
Unknown Object (File)
Sep 29 2024, 3:11 PM
Unknown Object (File)
Sep 20 2024, 10:16 PM
Subscribers

Details

Summary

In order to update our grpc-web codegen, we need to run protoc with some specific parameters, and then rename the files. I figured it would be good to put this into a Yarn script so we don't have to remember it / pull it from some diff's test plan every time.

Note that after running this script, some more work is necessary. There are a couple small modifications necessary to the .cjs files (update the imported filename and add @generated annotations), but the bulk of the work is in converting the TypeScript libraries to Flow.

Depends on D9490

Test Plan

Run the script

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

web/scripts/codegen-identity-grpc.sh
12 ↗(On Diff #32000)

Flow is confused by the @generated that appears here, so is collapsing this file

Adding this comment so the file isn't collapsed

varun added inline comments.
web/scripts/codegen-identity-grpc.sh
12 ↗(On Diff #32000)

any change to this file in the future won't appear on phab. how about this?

This revision is now accepted and ready to land.Oct 13 2023, 1:46 PM
This revision was landed with ongoing or failed builds.Oct 17 2023, 6:10 AM
This revision was automatically updated to reflect the committed changes.