Page MenuHomePhabricator

[keyserver] fix production check while uploading keys to Identity
ClosedPublic

Authored by kamil on Oct 16 2023, 11:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 3:13 PM
Unknown Object (File)
Sun, Oct 27, 3:13 PM
Unknown Object (File)
Sun, Oct 27, 3:13 PM
Unknown Object (File)
Sun, Oct 27, 3:11 PM
Unknown Object (File)
Sep 27 2024, 9:21 PM
Unknown Object (File)
Sep 21 2024, 9:18 PM
Unknown Object (File)
Sep 12 2024, 1:51 AM
Unknown Object (File)
Sep 10 2024, 10:10 AM
Subscribers

Details

Summary

Fixing regression introduced in D9427.

This shouldn't affect anything, the only risk is that migration could make a silent fail on prod because the condition returns false always - but this is not what we want.

I discovered on my local setup that process.env.NODE_ENV === 'production' will not work because this env value is never set to production (this might be the fault of some missing .env files on my setup), but based on the code we only set NODE_ENV for dev, so changing this for safer solution.

Test Plan
  1. Terminate Identity
  2. Test migration on prod (fail) / dev (only warning)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable