Page MenuHomePhabricator

[keyserver] fix production check while uploading keys to Identity
ClosedPublic

Authored by kamil on Oct 16 2023, 11:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 10:27 AM
Unknown Object (File)
Mon, Dec 16, 10:27 AM
Unknown Object (File)
Sat, Dec 14, 9:01 PM
Unknown Object (File)
Thu, Dec 12, 12:03 PM
Unknown Object (File)
Mon, Dec 9, 11:21 AM
Unknown Object (File)
Oct 27 2024, 3:13 PM
Unknown Object (File)
Oct 27 2024, 3:13 PM
Unknown Object (File)
Oct 27 2024, 3:13 PM
Subscribers

Details

Summary

Fixing regression introduced in D9427.

This shouldn't affect anything, the only risk is that migration could make a silent fail on prod because the condition returns false always - but this is not what we want.

I discovered on my local setup that process.env.NODE_ENV === 'production' will not work because this env value is never set to production (this might be the fault of some missing .env files on my setup), but based on the code we only set NODE_ENV for dev, so changing this for safer solution.

Test Plan
  1. Terminate Identity
  2. Test migration on prod (fail) / dev (only warning)

Diff Detail

Repository
rCOMM Comm
Branch
fix-prod-dev
Lint
No Lint Coverage
Unit
No Test Coverage