Page MenuHomePhabricator
Differential D9531

[commtest] Fix code version for grpc client tests
ClosedPublic
Actions

Authored by bartek on Oct 19 2023, 1:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 4:38 PM
Unknown Object (File)
Wed, Nov 20, 4:37 PM
Unknown Object (File)
Wed, Nov 20, 4:18 PM
Unknown Object (File)
Wed, Nov 13, 8:12 PM
Unknown Object (File)
Sun, Nov 10, 2:29 AM
Unknown Object (File)
Oct 19 2024, 4:20 AM
Unknown Object (File)
Oct 19 2024, 4:20 AM
View All 60 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
varun
• jon
Commits
rCOMM06f338b02b34: [commtest] Fix code version for grpc client tests
Summary

Identity service has min-version hardcoded to 270 while the test was providing 100, which caused failure due to "Unsupported version".
Changed it to 1000 to give us some time. When it fails next time we can bump it up again, unless we have better ways of setting the value.

Test Plan

The test no longer fails

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
commtest/
tests/
2 lines

Diff 32178

View Options

services/commtest/tests/grpc_client_test.rs

Loading...