Paths

Table of Contentst

Differential D9531

[commtest] Fix code version for grpc client tests
ClosedPublic
Actions

Authored by bartek on Oct 19 2023, 1:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 2:29 AM

	Unknown Object (File)
	Sat, Oct 19, 4:20 AM

	Unknown Object (File)
	Sat, Oct 19, 4:20 AM

	Unknown Object (File)
	Sat, Oct 19, 4:18 AM

	Unknown Object (File)
	Sat, Oct 19, 4:02 AM

	Unknown Object (File)
	Sep 19 2024, 3:19 AM

	Unknown Object (File)
	Sep 14 2024, 6:34 PM

	Unknown Object (File)
	Sep 14 2024, 6:34 PM

View All 55 Files

Subscribers

Details

Reviewers

varun
• jon

Commits

rCOMM06f338b02b34: [commtest] Fix code version for grpc client tests

Summary

Identity service has min-version hardcoded to 270 while the test was providing 100, which caused failure due to "Unsupported version".
Changed it to 1000 to give us some time. When it fails next time we can bump it up again, unless we have better ways of setting the value.

Test Plan

The test no longer fails

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Oct 19 2023, 1:22 AM

bartek held this revision as a draft.

Herald added a reviewer: • jon. · View Herald TranscriptOct 19 2023, 1:22 AM

Herald added subscribers: will, tomek, ashoat. · View Herald Transcript

Harbormaster completed remote builds in B23349: Diff 32178.Oct 19 2023, 1:39 AM

bartek published this revision for review.Oct 20 2023, 1:43 AM

sorry about that! thanks for fixing

This revision is now accepted and ready to land.Oct 20 2023, 6:35 AM

Closed by commit rCOMM06f338b02b34: [commtest] Fix code version for grpc client tests (authored by bartek). · Explain WhyOct 20 2023, 9:22 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM06f338b02b34: [commtest] Fix code version for grpc client tests.

Revision Contents
Changeset List

Path

Size

services/

commtest/

tests/

grpc_client_test.rs

2 lines

Diff 32178

services/commtest/tests/grpc_client_test.rs

Loading...