Paths

Table of Contentst

Differential D9569

[Buildkite] Add automatic retries to `CommTest` workflow
ClosedPublic
Actions

Authored by atul on Oct 24 2023, 8:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 20, 6:01 PM

	Unknown Object (File)
	Sat, Nov 16, 9:02 PM

	Unknown Object (File)
	Sat, Nov 16, 9:02 PM

	Unknown Object (File)
	Sat, Nov 16, 9:02 PM

	Unknown Object (File)
	Sat, Nov 16, 9:02 PM

	Unknown Object (File)
	Sat, Nov 16, 9:02 PM

	Unknown Object (File)
	Sat, Nov 16, 9:01 PM

	Unknown Object (File)
	Thu, Nov 14, 10:43 PM

View All 69 Files

Subscribers

Details

Reviewers

bartek
ashoat

Commits

rCOMM7b83cf87f8e6: [Buildkite] Add automatic retries to `CommTest` workflow

Summary

Try to reduce failures when there are intermittent outages of whatever dependencies.

Test Plan

NA

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Oct 24 2023, 8:19 AM

Herald added subscribers: will, tomek. · View Herald TranscriptOct 24 2023, 8:19 AM

atul published this revision for review.Oct 24 2023, 8:22 AM

Harbormaster failed remote builds in B23437: Diff 32337!Oct 24 2023, 8:28 AM

retry

Harbormaster failed remote builds in B23438: Diff 32338!Oct 24 2023, 9:22 AM

ashoat accepted this revision.Oct 24 2023, 11:15 AM

This revision is now accepted and ready to land.Oct 24 2023, 11:15 AM

rebase and land

This revision was landed with ongoing or failed builds.Oct 24 2023, 2:52 PM

Closed by commit rCOMM7b83cf87f8e6: [Buildkite] Add automatic retries to `CommTest` workflow (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM7b83cf87f8e6: [Buildkite] Add automatic retries to `CommTest` workflow.

Harbormaster failed remote builds in B23465: Diff 32368!Oct 24 2023, 3:02 PM

@atul I think this doesn't work now

.buildkite/commtest.yml
7–8	Shouldn't this `retry` be one level higher? At the step level, not the plugin config level?

atul added inline comments.Oct 26 2023, 12:25 PM

.buildkite/commtest.yml
7–8	Ah yeah. Usually `retry` is right below `command`, but looks like things might be different here and it should be moved out to same level as `label`. Will put up a diff fixing this rn.

atul mentioned this in D9614: [Buildkite] Move `commtest` `retry` setting to upper level.Oct 26 2023, 12:27 PM

atul added inline comments.Oct 26 2023, 12:27 PM

.buildkite/commtest.yml
7–8	https://phab.comm.dev/D9614

atul mentioned this in rCOMMa56849ceb0c2: [Buildkite] Move `commtest` `retry` setting to upper level.Oct 26 2023, 1:08 PM

Revision Contents
Changeset List

Path

Size

.buildkite/

2 lines

Diff 32369

.buildkite/commtest.yml

Loading...