Page MenuHomePhabricator

Merge all redux actions mutating cryptoStore into one.
ClosedPublic

Authored by marcin on Oct 25 2023, 3:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 29, 7:45 AM
Unknown Object (File)
Tue, Oct 29, 7:43 AM
Unknown Object (File)
Tue, Oct 29, 5:20 AM
Unknown Object (File)
Sun, Oct 27, 9:02 PM
Unknown Object (File)
Oct 4 2024, 6:34 PM
Unknown Object (File)
Oct 1 2024, 10:16 PM
Unknown Object (File)
Sep 29 2024, 12:51 AM
Unknown Object (File)
Sep 29 2024, 12:51 AM
Subscribers

Details

Summary

This differential was created in response to the issue pointed by Ashoat: https://phab.comm.dev/D9532#inline-60290. Cryptographically, it doesn't make
sense in our project to have primaryAccount set but nulled notificationAccount. Additionally it doesn't make sense if there is primaryAccount but there are
no primaryIdentityKeys. That said we need one redux action to set entire CryptoStore at once and this part of redux should either have all fields set all be null.

Test Plan

Log-in and Log-out while observing Redux extension of Developer Tools. Ensure that LOG_OUT_SUCCESS action succesfully changes CryptoStore to null and
shortly SET_CRYPTO_STORE action is dispatched that correctly sets entire CryptoStore.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Rebase to update commit message

This revision is now accepted and ready to land.Oct 26 2023, 10:30 AM
web/selectors/tunnelbroker-selectors.js
11

Why was the ? removed before .ed25519? This caused a major issue: ENG-5904

web/selectors/tunnelbroker-selectors.js
11

My mistake indeed. This issue didn't occur during my testing.