Page MenuHomePhabricator
Differential D9533

Enforce getSignedIdentityKeysBlob in socket selectors
ClosedPublic
Actions

Authored by marcin on Oct 19 2023, 3:35 AM.
Tags
None
Referenced Files
F5894342: D9533.id32181.diff
Thu, Apr 17, 10:17 AM
Unknown Object (File)
Tue, Apr 15, 8:37 PM
Unknown Object (File)
Wed, Apr 9, 7:38 AM
Unknown Object (File)
Wed, Apr 9, 12:57 AM
Unknown Object (File)
Tue, Apr 8, 11:31 PM
Unknown Object (File)
Tue, Apr 8, 11:30 PM
Unknown Object (File)
Tue, Apr 8, 10:49 PM
Unknown Object (File)
Tue, Apr 8, 10:27 PM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
kamil
michal
Commits
rCOMMc978bf24d7cf: Enforce getSignedIdentityKeysBlob in socket selectors
Summary

Changes introduced in parent differential allow us to make getSignedIdentityKeysBlob a non-optional argument for socket selectors.

Test Plan

Run flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Oct 19 2023, 3:35 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 19 2023, 3:35 AM
marcin added a parent revision: D9532: Refactor olm accounts lifecycle on web.Oct 19 2023, 3:37 AM
marcin added a child revision: D9534: Extract shareable notifications session creation logic to lib.
marcin updated this revision to Diff 32185.Oct 19 2023, 3:44 AM

Rebase to update commit message

Harbormaster completed remote builds in B23352: Diff 32181.Oct 19 2023, 3:52 AM
Harbormaster completed remote builds in B23356: Diff 32185.Oct 19 2023, 4:01 AM
marcin requested review of this revision.Oct 19 2023, 4:01 AM
marcin edited the summary of this revision. (Show Details)Oct 19 2023, 4:09 AM
marcin edited the test plan for this revision. (Show Details)
atul accepted this revision.Oct 23 2023, 9:32 AM
This revision is now accepted and ready to land.Oct 23 2023, 9:32 AM
marcin updated this revision to Diff 32422.Oct 26 2023, 3:53 AM
marcin edited the summary of this revision. (Show Details)

Rebase

Harbormaster completed remote builds in B23506: Diff 32422.Oct 26 2023, 4:50 AM
marcin updated this revision to Diff 33537.Nov 23 2023, 2:01 AM

Rebase before landing

Harbormaster completed remote builds in B24357: Diff 33537.Nov 23 2023, 2:47 AM
Closed by commit rCOMMc978bf24d7cf: Enforce getSignedIdentityKeysBlob in socket selectors (authored by marcin). · Explain WhyNov 23 2023, 5:49 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMc978bf24d7cf: Enforce getSignedIdentityKeysBlob in socket selectors.

Revision Contents
Changeset List

PathSize
lib/
selectors/
7 lines
native/
selectors/
2 lines

Diff 33558

View Options

lib/selectors/socket-selectors.js

Show First 20 Lines • Show All 658 Lines • ▼ Show 20 Lines async () => {
AND (t.type = ${threadTypes.COMMUNITY_ROOT} AND (t.type = ${threadTypes.COMMUNITY_ROOT}
OR t.type = ${threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT}) OR t.type = ${threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT})
`); `);
await dbQuery(updateQuery); await dbQuery(updateQuery);
}, },
], ],
[52, updateRolesAndPermissionsForAllThreads], [52, updateRolesAndPermissionsForAllThreads],
[
53,
async () =>
dbQuery(SQL`
ALTER TABLE invite_links
ADD COLUMN blob_holder char(36) CHARSET latin1
`),
],
]); ]);
const newDatabaseVersion: number = Math.max(...migrations.keys()); const newDatabaseVersion: number = Math.max(...migrations.keys());
async function writeJSONToFile(data: any, filePath: string): Promise<void> { async function writeJSONToFile(data: any, filePath: string): Promise<void> {
console.warn(`updating ${filePath} to ${JSON.stringify(data)}`); console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);
const fileHandle = await fs.promises.open(filePath, 'w'); const fileHandle = await fs.promises.open(filePath, 'w');
await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8'); await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');
await fileHandle.close(); await fileHandle.close();
▲ Show 20 Lines • Show All 118 Lines • Show Last 20 Lines
View Options

native/selectors/socket-selectors.js

Show First 20 Lines • Show All 658 Lines • ▼ Show 20 Lines async () => {
AND (t.type = ${threadTypes.COMMUNITY_ROOT} AND (t.type = ${threadTypes.COMMUNITY_ROOT}
OR t.type = ${threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT}) OR t.type = ${threadTypes.COMMUNITY_ANNOUNCEMENT_ROOT})
`); `);
await dbQuery(updateQuery); await dbQuery(updateQuery);
}, },
], ],
[52, updateRolesAndPermissionsForAllThreads], [52, updateRolesAndPermissionsForAllThreads],
[
53,
async () =>
dbQuery(SQL`
ALTER TABLE invite_links
ADD COLUMN blob_holder char(36) CHARSET latin1
`),
],
]); ]);
const newDatabaseVersion: number = Math.max(...migrations.keys()); const newDatabaseVersion: number = Math.max(...migrations.keys());
async function writeJSONToFile(data: any, filePath: string): Promise<void> { async function writeJSONToFile(data: any, filePath: string): Promise<void> {
console.warn(`updating ${filePath} to ${JSON.stringify(data)}`); console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);
const fileHandle = await fs.promises.open(filePath, 'w'); const fileHandle = await fs.promises.open(filePath, 'w');
await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8'); await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');
await fileHandle.close(); await fileHandle.close();
▲ Show 20 Lines • Show All 118 Lines • Show Last 20 Lines