Changes introduced in parent differential allow us to make getSignedIdentityKeysBlob a non-optional argument for socket selectors.
Details
Details
Summary
Test Plan
Run flow
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 19 2023, 10:35 AM2023-10-19 10:35:27 (UTC+0)
marcin added a parent revision: D9532: Refactor olm accounts lifecycle on web.Oct 19 2023, 10:37 AM2023-10-19 10:37:46 (UTC+0)
marcin added a child revision: D9534: Extract shareable notifications session creation logic to lib.
Harbormaster completed remote builds in B23352: Diff 32181.Oct 19 2023, 10:52 AM2023-10-19 10:52:52 (UTC+0)
Harbormaster completed remote builds in B23356: Diff 32185.Oct 19 2023, 11:01 AM2023-10-19 11:01:54 (UTC+0)
marcin edited the summary of this revision. (Show Details)Oct 19 2023, 11:09 AM2023-10-19 11:09:57 (UTC+0)
This revision is now accepted and ready to land.Oct 23 2023, 4:32 PM2023-10-23 16:32:36 (UTC+0)
Harbormaster completed remote builds in B23506: Diff 32422.Oct 26 2023, 11:50 AM2023-10-26 11:50:13 (UTC+0)
Harbormaster completed remote builds in B24357: Diff 33537.Nov 23 2023, 10:47 AM2023-11-23 10:47:36 (UTC+0)
Closed by commit rCOMMc978bf24d7cf: Enforce getSignedIdentityKeysBlob in socket selectors. · Explain WhyNov 23 2023, 1:49 PM2023-11-23 13:49:48 (UTC+0)
This revision was automatically updated to reflect the committed changes.