[lib] Avoid unnecessary Set construction in RadixTree.getAllMatchingExactly
ClosedPublic
Actions

Authored by ashoat on Oct 31 2023, 5:05 AM.

Details

Reviewers

tomek
atul
inka
rohan

Commits

rCOMM74aeaf7eac1b: [lib] Avoid unnecessary Set construction in RadixTree.getAllMatchingExactly

Summary

Noticed this after landing the diff here. The underlying data is a Set anyways, so all this does it copy the Set. We don't return the original Set anyways, so there is no point to this.

Depends on D9646

Test Plan

Flow, careful code inspection

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 31 2023, 5:05 AM

Herald added a subscriber: will. · View Herald TranscriptOct 31 2023, 5:05 AM

ashoat published this revision for review.Oct 31 2023, 5:11 AM

ashoat mentioned this in D9626: [lib] Introduce RadixTree.Oct 31 2023, 5:17 AM

Harbormaster completed remote builds in B23591: Diff 32532.Oct 31 2023, 5:24 AM

Good catch

This revision is now accepted and ready to land.Oct 31 2023, 5:53 AM

Closed by commit rCOMM74aeaf7eac1b: [lib] Avoid unnecessary Set construction in RadixTree.getAllMatchingExactly (authored by ashoat). · Explain WhyOct 31 2023, 6:55 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM74aeaf7eac1b: [lib] Avoid unnecessary Set construction in RadixTree.getAllMatchingExactly.

Revision Contents
Changeset List

Path

Size

lib/

shared/

radix-tree.js

2 lines

Diff 32541

View Options

[lib] Avoid unnecessary Set construction in RadixTree.getAllMatchingExactlyClosedPublicActions