Details
Unit tests, will add a few more.
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Please make sure to address the last two comments before landing
| lib/permissions/minimally-encoded-thread-permissions.js | ||
|---|---|---|
| 115–129 ↗ | (On Diff #32573) | Seems like a bit of code duplication here... I wonder if it would be worth defining a generic inverseMap function in lib/utils/objects.js. Not sure how hard the Flow types would be |
| 132 ↗ | (On Diff #32573) | Wondering – why'd you skip the & BigInt(63) part here? |
| 142–147 ↗ | (On Diff #32573) | Some typos here, you're passing 4 params instead of 2 |
| lib/permissions/minimally-encoded-thread-permissions.js | ||
|---|---|---|
| 142–147 ↗ | (On Diff #32573) | Dang, really should've caught this. Intended to copy/paste the first line and replace the , with &&. |
| lib/permissions/minimally-encoded-thread-permissions.js | ||
|---|---|---|
| 132 ↗ | (On Diff #32573) | We don't really need to, but it doesn't hurt to add in case we're given malformed input (bitmask exceeds 12 bits).  When we shift right 4, we're "pushing" the propagation bits and filter bits off the edge.. so we're only left with the base bits. However, when we shift right 2 to get propagation bits, and shift 0 to get filter bits (c and d in attached snippet)... we have "extraneous" more significant bits that we want to "mask away." |
| lib/permissions/minimally-encoded-thread-permissions.js | ||
|---|---|---|
| 115–129 ↗ | (On Diff #32573) | Ran into some flow issues, made a linear task to unblock landing this diff: https://linear.app/comm/issue/ENG-5640/consider-introducing-invertobjecttomap-utility-fn |