Page MenuHomePhabricator

[web] add client interceptors for grpc-web
ClosedPublic

Authored by varun on Nov 1 2023, 6:30 PM.
Tags
None
Referenced Files
F3397727: D9672.diff
Sun, Dec 1, 7:12 PM
Unknown Object (File)
Mon, Nov 18, 8:37 PM
Unknown Object (File)
Mon, Nov 18, 8:27 PM
Unknown Object (File)
Wed, Nov 13, 12:51 PM
Unknown Object (File)
Wed, Nov 13, 12:51 PM
Unknown Object (File)
Wed, Nov 13, 12:48 PM
Unknown Object (File)
Tue, Nov 12, 4:20 PM
Unknown Object (File)
Oct 20 2024, 9:11 AM
Subscribers

Details

Summary

these interceptors will be used to add version and auth metadata to our RPCs.

Depends on D9671

Test Plan

Diff Detail

Repository
rCOMM Comm
Branch
grpc-web (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.Nov 1 2023, 6:58 PM

JS code looks fine but I don't really know anything about gRPC interceptors... should somebody else with context on those review this as well?

This revision is now accepted and ready to land.Nov 2 2023, 6:55 AM

JS code looks fine but I don't really know anything about gRPC interceptors... should somebody else with context on those review this as well?

i think @bartek is the only other person with context on interceptors and he's out the rest of the week. i think it's ok to proceed without further review since this code is pretty straightforward and has been tested extensively

This revision was automatically updated to reflect the committed changes.