Handy utility function that will make encoding/decoding of permissions/role permissions much simpler at callsite and avoid polluting with a bunch of permission encoding related stuff in eg rawThreadInfosFromServerThreadInfos.
Depends on D9736
Details
Details
Single unit test for now, will add more after decode function is introduced.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/permissions/minimally-encoded-thread-permissions.js | ||
|---|---|---|
| 213–232 ↗ | (On Diff #32840) | For currentUserInfo and memberInfo, permissions are of type ThreadPermissionsInfo and look like: know_of: { value: true, source: '1' }, visible: { value: true, source: '1' }, voiced: { value: true, source: '1' }, Whereas for roleInfo, they're of type ThreadPermissionsBlob which look like: descendant_open_know_of: true, descendant_open_visible: true, descendant_opentoplevel_join_thread: true, edit_entries: true, edit_message: true, edit_permissions: true, edit_thread: true, edit_thread_avatar: true, It's definitely a bit confusing because of the naming of the types is similar and the "key" in all of the objects is permissions. |
| 213–232 ↗ | (On Diff #32840) | (Let me know if there's something I'm missing and didn't answer question you were asking) |
| 275–280 ↗ | (On Diff #32840) | Oh true, that's a lot cleaner! Will update this diff, thanks for flagging that |
| lib/permissions/minimally-encoded-thread-permissions.js | ||
|---|---|---|
| 213–232 ↗ | (On Diff #32840) | Thanks! That makes sense |