[lib] Determine update info key in a spec
ClosedPublic
Actions

Authored by tomek on Nov 7 2023, 2:16 PM.

Details

Reviewers

kamil
inka
bartek

Commits

rCOMM8005048b509e: [lib] Determine update info key in a spec

Summary

Move the code to specs.

Depends on D9744

https://linear.app/comm/issue/ENG-4233/introduce-update-specs-containing-functions-from-update-utils

Test Plan

Reintroduce the old code and check if it gives the same result.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Nov 7 2023, 2:16 PM

Herald added subscribers: will, ashoat. · View Herald TranscriptNov 7 2023, 2:16 PM

tomek added a child revision: D9746: [lib] Convert update data into raw update info in a spec.Nov 7 2023, 2:17 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2023, 2:31 PM

Harbormaster failed remote builds in B23853: Diff 32874!

Rebase

Harbormaster completed remote builds in B23908: Diff 32945.Nov 8 2023, 8:48 PM

tomek requested review of this revision.Nov 8 2023, 8:48 PM

kamil accepted this revision.Nov 9 2023, 2:53 PM

This revision is now accepted and ready to land.Nov 9 2023, 2:53 PM

Closed by commit rCOMM8005048b509e: [lib] Determine update info key in a spec. · Explain WhyNov 10 2023, 12:33 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM8005048b509e: [lib] Determine update info key in a spec.

Revision Contents
Changeset List

Path

Size

lib/

shared/

update-utils.js

23 lines

updates/

delete-account-spec.js

3 lines

delete-thread-spec.js

3 lines

join-thread-spec.js

3 lines

update-current-user-spec.js

3 lines

update-entry-spec.js

5 lines

update-spec.js

1 line

update-thread-read-status-spec.js

3 lines

update-thread-spec.js

3 lines

update-user-spec.js

3 lines

Diff 33060

View Options

lib/shared/update-utils.js

View Options

lib/shared/updates/delete-account-spec.js

View Options

lib/shared/updates/delete-thread-spec.js

View Options

lib/shared/updates/join-thread-spec.js

View Options

lib/shared/updates/update-current-user-spec.js

View Options

lib/shared/updates/update-entry-spec.js

View Options

lib/shared/updates/update-spec.js

View Options

lib/shared/updates/update-thread-read-status-spec.js

View Options

lib/shared/updates/update-thread-spec.js

View Options

lib/shared/updates/update-user-spec.js

[lib] Determine update info key in a specClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33060

lib/shared/update-utils.js

lib/shared/updates/delete-account-spec.js

lib/shared/updates/delete-thread-spec.js

lib/shared/updates/join-thread-spec.js

lib/shared/updates/update-current-user-spec.js

lib/shared/updates/update-entry-spec.js

lib/shared/updates/update-spec.js

lib/shared/updates/update-thread-read-status-spec.js

lib/shared/updates/update-thread-spec.js

lib/shared/updates/update-user-spec.js

[lib] Determine update info key in a spec
ClosedPublic
Actions

Revision Contents
Changeset List