Page MenuHomePhabricator
Differential D9766

[lib] Add `minimallyEncoded` discriminator property to `MinimallyEncodedRawThreadInfo`
ClosedPublic
Actions

Authored by atul on Nov 8 2023, 10:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 8, 9:43 AM
Unknown Object (File)
Thu, Feb 20, 11:39 PM
Unknown Object (File)
Thu, Feb 20, 11:39 PM
Unknown Object (File)
Thu, Feb 20, 11:38 PM
Unknown Object (File)
Thu, Feb 20, 11:34 PM
Unknown Object (File)
Feb 19 2025, 7:18 AM
Unknown Object (File)
Feb 16 2025, 6:14 PM
Unknown Object (File)
Feb 13 2025, 4:13 AM
View All 71 Files
Subscribers
will

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM878c958c284e: [lib] Add `minimallyEncoded` discriminator property to…
Summary

As part of refactoring keyserver/native/web, there are places where we need to replace RawThreadInfo with RawThreadInfo | MinimallyEncodedRawThreadInfo. However, both types currently have the exact same keys, so it's difficult to refine types without duplicating functions, "drilling down" minimallyEncoded boolean to downstream functions, etc.

Instead, we add minimallyEncoded discriminator property to allow for more precise type refinement b/w RawThreadInfo and MinimallyEncodedRawThreadInfo.

Here's kind of what I'm going for: https://flow.org/try/#1N4Igxg9gdgZglgcxALlAIwIZoKYBsD6uEEAztvhgE6UYCe+JADpdhgCYowa5kA0I2KAFcAtiRQAXSkOz9sADwxgJ+NPTbYuQ3BMnTZA+Y2yU4IwRO4A6SFBIrGVDGM7c+IFkolXpUCWewUEAwhCQgRDH8wEH4hMnwROHlsNnw4KHwwSLAAC3wANyo4LFxscWQuHgMNZmwsiRSAWglaY1cq-hIAa2wJXNpG4Vxcdvdu3v7B0RxKUYMhKDBSqmbWwOQpGVioKDqykioB9MLTDD857d2wfcPGiEZ-aG5G3Ix0i5AFg5hsRoRehqUEiNMgSQHlSruBZxJrMcJwMhzAC+-EgGiCLWMAAIAEoYADuABUcp42ABJWAQLEAXixwAAOlAsVi4GxkFj7KYoAheIzmVBnNh2Zz0jy+VjjJREiQSHBoCR2fSQPB8tglYykQBuRmMzHYLEAWXSZm4uFoAFFFhANGw8USSaxyZSaXTxYkoCbhharTb2ZtZOLWcKpKLeUysYI0aKAMq5bDmdnAINYpU5PBEJUo8WS6Wy+XsgCsGu1UF1ayxxNJFJgVNpdsrjurVIAPobjREvZa0Sl6w72E2S4yYAtlHKmf8JE2ABQSPtOmvshv9ykASld4eZcBgWJnc6bVndnrNXetKTXDI3zKvthIEFKViICF3VcpVkj1pjcfMK-FV+v8rvbAHwgJ9ZxfGsrBzBE8zsLEACosQARgABh-S8kQjKp1z-P8b0A4DQL3V93zYT802-X8cLw+9H2fRtXygmUxxIeCkNQyikQ1RkYhAVUgTHIJ8mQqwACYROExCQCRIA

Test Plan

Unit tests still pass, should make subsequent refactoring simpler.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 32952

View Options

lib/permissions/minimally-encoded-thread-permissions-test-data.js

Show First 20 Lines • Show All 274 Lines • ▼ Show 20 Linesconst registerRequestInputValidator = tShape<RegisterRequest>({
password: tPassword, password: tPassword,
calendarQuery: t.maybe(newEntryQueryInputValidator), calendarQuery: t.maybe(newEntryQueryInputValidator),
deviceTokenUpdateRequest: t.maybe(deviceTokenUpdateRequestInputValidator), deviceTokenUpdateRequest: t.maybe(deviceTokenUpdateRequestInputValidator),
platformDetails: tPlatformDetails, platformDetails: tPlatformDetails,
// We include `primaryIdentityPublicKey` to avoid breaking // We include `primaryIdentityPublicKey` to avoid breaking
// old clients, but we no longer do anything with it. // old clients, but we no longer do anything with it.
primaryIdentityPublicKey: t.maybe(tRegex(primaryIdentityPublicKeyRegex)), primaryIdentityPublicKey: t.maybe(tRegex(primaryIdentityPublicKeyRegex)),
signedIdentityKeysBlob: t.maybe(signedIdentityKeysBlobValidator), signedIdentityKeysBlob: t.maybe(signedIdentityKeysBlobValidator),
initialNotificationsEncryptedMessage: t.maybe(t.String),
}); });
export const registerResponseValidator: TInterface<RegisterResponse> = export const registerResponseValidator: TInterface<RegisterResponse> =
tShape<RegisterResponse>({ tShape<RegisterResponse>({
id: t.String, id: t.String,
rawMessageInfos: t.list(rawMessageInfoValidator), rawMessageInfos: t.list(rawMessageInfoValidator),
currentUserInfo: t.union([ currentUserInfo: t.union([
oldLoggedInUserInfoValidator, oldLoggedInUserInfoValidator,
▲ Show 20 Lines • Show All 536 Lines • Show Last 20 Lines
View Options

lib/permissions/minimally-encoded-thread-permissions.js

Show First 20 Lines • Show All 274 Lines • ▼ Show 20 Linesconst registerRequestInputValidator = tShape<RegisterRequest>({
password: tPassword, password: tPassword,
calendarQuery: t.maybe(newEntryQueryInputValidator), calendarQuery: t.maybe(newEntryQueryInputValidator),
deviceTokenUpdateRequest: t.maybe(deviceTokenUpdateRequestInputValidator), deviceTokenUpdateRequest: t.maybe(deviceTokenUpdateRequestInputValidator),
platformDetails: tPlatformDetails, platformDetails: tPlatformDetails,
// We include `primaryIdentityPublicKey` to avoid breaking // We include `primaryIdentityPublicKey` to avoid breaking
// old clients, but we no longer do anything with it. // old clients, but we no longer do anything with it.
primaryIdentityPublicKey: t.maybe(tRegex(primaryIdentityPublicKeyRegex)), primaryIdentityPublicKey: t.maybe(tRegex(primaryIdentityPublicKeyRegex)),
signedIdentityKeysBlob: t.maybe(signedIdentityKeysBlobValidator), signedIdentityKeysBlob: t.maybe(signedIdentityKeysBlobValidator),
initialNotificationsEncryptedMessage: t.maybe(t.String),
}); });
export const registerResponseValidator: TInterface<RegisterResponse> = export const registerResponseValidator: TInterface<RegisterResponse> =
tShape<RegisterResponse>({ tShape<RegisterResponse>({
id: t.String, id: t.String,
rawMessageInfos: t.list(rawMessageInfoValidator), rawMessageInfos: t.list(rawMessageInfoValidator),
currentUserInfo: t.union([ currentUserInfo: t.union([
oldLoggedInUserInfoValidator, oldLoggedInUserInfoValidator,
▲ Show 20 Lines • Show All 536 Lines • Show Last 20 Lines