Paths

Table of Contentst

Differential D9787

[lib] Use `RawThreadInfos` type everywhere
ClosedPublic
Actions

Authored by atul on Nov 8 2023, 1:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 13, 10:05 AM

	Unknown Object (File)
	Wed, Nov 13, 12:04 AM

	Unknown Object (File)
	Tue, Nov 12, 11:18 PM

	Unknown Object (File)
	Tue, Nov 12, 11:18 PM

	Unknown Object (File)
	Oct 14 2024, 9:50 PM

	Unknown Object (File)
	Oct 12 2024, 2:23 AM

	Unknown Object (File)
	Oct 12 2024, 2:23 AM

	Unknown Object (File)
	Oct 12 2024, 2:23 AM

View All 53 Files

Subscribers

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM6609133ca9dd: [lib] Use `RawThreadInfos` type everywhere

Summary

In some places we were using RawThreadInfos, in others we were using { +[id: string]: RawThreadInfo }, and in others we were using { +[threadID: string]: RawThreadInfo }.

This is just for convenience when refactoring. Searching for RawThreadInfos or using "go to usages" will actually show us all uses of this type: https://blob.sh/68308a.png

Test Plan

NA

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 8 2023, 1:38 PM

Herald added a subscriber: will. · View Herald TranscriptNov 8 2023, 1:38 PM

atul published this revision for review.Nov 8 2023, 1:38 PM

atul retitled this revision from [lib] Use `RawThreadInfos` everywhere to [lib] Use `RawThreadInfos` type everywhere.

ashoat accepted this revision.Nov 8 2023, 1:47 PM

This revision is now accepted and ready to land.Nov 8 2023, 1:47 PM

Harbormaster completed remote builds in B23935: Diff 32978.Nov 8 2023, 4:52 PM

Closed by commit rCOMM6609133ca9dd: [lib] Use `RawThreadInfos` type everywhere (authored by atul). · Explain WhyNov 9 2023, 11:49 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6609133ca9dd: [lib] Use `RawThreadInfos` type everywhere.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

update-creator.js

4 lines

lib/

actions/

user-actions.js

4 lines

ops/

thread-store-ops.js

3 lines

reducers/

calendar-filters-reducer.js

4 lines

entry-reducer.js

6 lines

message-reducer.js

14 lines

thread-reducer.js

4 lines

selectors/

thread-selectors.js

19 lines

types/

account-types.js

10 lines

report-types.js

12 lines

session-types.js

6 lines

socket-types.js

4 lines

thread-types.js

4 lines

native/

redux/

edit-thread-permission-migration.js

3 lines

manage-pins-permission-migration.js

3 lines

selectors/

message-selectors.js

4 lines

web/

redux/

4 lines

selectors/

thread-selectors.js

7 lines

Diff 33025

keyserver/src/creators/update-creator.js

Loading...

lib/actions/user-actions.js

Loading...

lib/ops/thread-store-ops.js

Loading...

lib/reducers/calendar-filters-reducer.js

Loading...

lib/reducers/entry-reducer.js

Loading...

lib/reducers/message-reducer.js

Loading...

lib/reducers/thread-reducer.js

Loading...

lib/selectors/thread-selectors.js

Loading...

lib/types/account-types.js

Loading...

lib/types/report-types.js

Loading...

lib/types/session-types.js

Loading...

lib/types/socket-types.js

Loading...

lib/types/thread-types.js

Loading...

native/redux/edit-thread-permission-migration.js

Loading...

native/redux/manage-pins-permission-migration.js

Loading...

native/selectors/message-selectors.js

Loading...

web/redux/nav-reducer.js

Loading...

web/selectors/thread-selectors.js

Loading...