[shared] introduce ping client method in grpc_clients crate
ClosedPublic
Actions

Authored by varun on Nov 9 2023, 2:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 24, 7:25 AM

	Unknown Object (File)
	Mon, Jun 24, 7:25 AM

	Unknown Object (File)
	Mon, Jun 24, 7:24 AM

	Unknown Object (File)
	Mon, Jun 24, 7:10 AM

	Unknown Object (File)
	Wed, Jun 19, 9:46 PM

	Unknown Object (File)
	Wed, Jun 19, 9:46 PM

	Unknown Object (File)
	Sat, Jun 15, 11:21 PM

	Unknown Object (File)
	Fri, Jun 14, 9:24 AM

Subscribers

Details

Reviewers

bartek
michal

Commits

rCOMM81924c6ebe69: [shared] introduce ping client method in grpc_clients crate

Summary

this is the method that clients will call periodically to make sure their code version is supported

Test Plan

tested in next diff by calling client method from js on native

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Nov 9 2023, 2:48 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptNov 9 2023, 2:48 PM

varun added a child revision: D9813: [native] add versionSupported method to CommRustModule.Nov 9 2023, 2:50 PM

Harbormaster completed remote builds in B23980: Diff 33038.Nov 9 2023, 3:07 PM

varun requested review of this revision.Nov 9 2023, 3:07 PM

bartek accepted this revision.Nov 9 2023, 10:45 PM

This revision is now accepted and ready to land.Nov 9 2023, 10:45 PM

Closed by commit rCOMM81924c6ebe69: [shared] introduce ping client method in grpc_clients crate (authored by varun). · Explain WhyNov 21 2023, 10:52 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM81924c6ebe69: [shared] introduce ping client method in grpc_clients crate.

Revision Contents
Changeset List

Path

Size

shared/

grpc_clients/

src/

identity/

unauthenticated/

client.rs

18 lines

Diff 33465

View Options

shared/grpc_clients/src/identity/unauthenticated/client.rs

[shared] introduce ping client method in grpc_clients crateClosedPublicActions