[lib] Introduce `MinimallyEncodedThreadInfo` type
ClosedPublic
Actions

Authored by atul on Nov 13 2023, 1:25 PM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM9564d2eed1d3: [lib] Introduce `MinimallyEncodedThreadInfo` type

Summary

We need corresponding MinimallyEncodedThreadInfo for MinimallyEncodedRawThreadInfo. The only really relevant difference between the two is that MinimallyEncodedThreadInfo has $ReadOnlyArray<MinimallyEncodedRelativeMemberInfo> in members field instead of $ReadOnlyArray<MinimallyEncodedMemberInfo>.

Depends on D9845

Test Plan

Flow. Earlier in the stack I was writing unit tests for all of these, but I think the value of unit tests for these is questionable. Will defer for now and consider writing at the end.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Nov 13 2023, 1:25 PM

This should be the second-to-last MinimallyEncoded* type that we introduce. We'll need a MinimallyEncodedResolvedThreadInfo for clients, but that'll be later in the stack.

Harbormaster completed remote builds in B24059: Diff 33149.Nov 13 2023, 2:01 PM

ashoat accepted this revision.Nov 13 2023, 2:04 PM

This revision is now accepted and ready to land.Nov 13 2023, 2:04 PM

atul added a child revision: D9847: [lib] Update signatures in `thread-utils` to handle `MinimallyEncodedThreadInfo`.Nov 13 2023, 2:13 PM

Closed by commit rCOMM9564d2eed1d3: [lib] Introduce `MinimallyEncodedThreadInfo` type (authored by atul). · Explain WhyNov 13 2023, 2:20 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM9564d2eed1d3: [lib] Introduce `MinimallyEncodedThreadInfo` type.