Page MenuHomePhabricator
Differential D9894

[web] Update misc parts of `web` to support `MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Authored by atul on Nov 15 2023, 7:01 AM.
Tags
None
Referenced Files
F3530279: D9894.id33352.diff
Wed, Dec 25, 1:50 AM
Unknown Object (File)
Fri, Dec 6, 1:35 AM
Unknown Object (File)
Tue, Nov 26, 5:26 PM
Unknown Object (File)
Tue, Nov 26, 5:15 PM
Unknown Object (File)
Tue, Nov 26, 1:10 PM
Unknown Object (File)
Nov 23 2024, 12:30 AM
Unknown Object (File)
Oct 26 2024, 1:01 AM
Unknown Object (File)
Oct 26 2024, 1:01 AM
View All 98 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
rohan
Commits
rCOMM8739b8508c3c: [web] Update misc parts of `web` to support `MinimallyEncodedThreadInfo`
Summary

Went through and made changes throughout web to support MinimallyEncodedThreadInfo where changes required were limited to updating signature.

Next diffs will involve changes that need to be made to native, message-specs, Redux, sendPushNotif, useResolvedThreadInfo, etc.

Test Plan

Trusting flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Nov 15 2023, 7:01 AM
atul published this revision for review.Nov 15 2023, 7:02 AM

There's more in web to be updated, but this first pass will make subsequent refactoring easy. Loosely starting with "leaf" components/functions and working way up.

atul edited the summary of this revision. (Show Details)Nov 15 2023, 7:04 AM
ashoat accepted this revision.Nov 15 2023, 8:09 AM
This revision is now accepted and ready to land.Nov 15 2023, 8:09 AM
Harbormaster completed remote builds in B24154: Diff 33268.Nov 15 2023, 8:15 AM
atul added a child revision: D9895: [native] Update misc parts of `native` to support `MinimallyEncodedThreadInfo`.Nov 15 2023, 8:19 AM
atul updated this revision to Diff 33352.Nov 16 2023, 10:57 AM

land

atul planned changes to this revision.Nov 16 2023, 10:57 AM
atul requested review of this revision.Nov 16 2023, 11:00 AM

misclick

This revision is now accepted and ready to land.Nov 16 2023, 11:00 AM
This revision was landed with ongoing or failed builds.Nov 16 2023, 11:01 AM
Closed by commit rCOMM8739b8508c3c: [web] Update misc parts of `web` to support `MinimallyEncodedThreadInfo` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM8739b8508c3c: [web] Update misc parts of `web` to support `MinimallyEncodedThreadInfo`.
Harbormaster failed remote builds in B24219: Diff 33352!Nov 16 2023, 11:25 AM

Revision Contents
Changeset List

Diff 33353

View Options

lib/shared/markdown.js

Loading...
View Options

web/avatars/edit-thread-avatar-menu.react.js

Loading...
View Options

web/avatars/edit-thread-avatar.react.js

Loading...
View Options

web/avatars/thread-avatar.react.js

Loading...
View Options

web/avatars/thread-emoji-avatar-selection-modal.react.js

Loading...
View Options

web/calendar/day.react.js

Loading...
View Options

web/chat/chat-thread-list-item-menu.react.js

Loading...
View Options

web/chat/chat-thread-list-see-more-sidebars.react.js

Loading...
View Options

web/chat/inline-engagement.react.js

Loading...
View Options

web/chat/message-tooltip.react.js

Loading...
View Options

web/chat/relationship-prompt/relationship-prompt.js

Loading...
View Options

web/chat/robotext-message.react.js

Loading...
View Options

web/invite-links/manage/edit-link-modal.react.js

Loading...
View Options

web/markdown/rules.react.js

Loading...
View Options

web/modals/search/message-search-utils.react.js

Loading...
View Options

web/modals/threads/gallery/thread-settings-media-gallery.react.js

Loading...
View Options

web/modals/threads/members/change-member-role-modal.react.js

Loading...
View Options

web/modals/threads/members/member.react.js

Loading...
View Options

web/modals/threads/members/members-list.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-delete-confirmation-modal.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-delete-tab.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-modal.react.js

Loading...
View Options

web/modals/threads/settings/thread-settings-privacy-tab.react.js

Loading...
View Options

web/modals/user-profile/user-profile-menu.react.js

Loading...
View Options

web/modals/user-profile/user-profile-message-button.react.js

Loading...
View Options

web/selectors/thread-selectors.js

Loading...
View Options

web/sidebar/community-drawer-item-community-handlers.react.js

Loading...
View Options

web/sidebar/community-drawer-item-handlers.react.js

Loading...
View Options

web/sidebar/community-drawer-utils.react.js

Loading...
View Options

web/sidebar/subchannels-button.react.js

Loading...