Page MenuHomePhabricator

[lib] Introduce `MinimallyEncodedResolvedThreadInfo` and start refactoring
ClosedPublic

Authored by atul on Nov 15 2023, 10:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 1:02 AM
Unknown Object (File)
Sat, Oct 26, 1:02 AM
Unknown Object (File)
Sat, Oct 26, 1:02 AM
Unknown Object (File)
Sat, Oct 26, 1:01 AM
Unknown Object (File)
Sat, Oct 26, 12:55 AM
Unknown Object (File)
Sat, Oct 12, 4:44 PM
Unknown Object (File)
Thu, Oct 10, 6:00 PM
Unknown Object (File)
Sep 28 2024, 3:41 PM
Subscribers
None

Details

Summary

We introduce MinimallyEncodedResolvedThreadInfo and start refactoring to accomodate the type everywhere that ResolvedThreadInfo is.

This diff handles a lot of the "simple stuff." The trickier stuff, specifically w/ useResolvedThread* hooks will be resolved in subsequent diffs.


Depends on D9895

Test Plan

Trusting flow here.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Nov 15 2023, 10:07 AM

I think there's a mistake here – see my inline comment. Please make sure to remove that change before landing (or if there's some good reason for it, can you re-request review)?

native/avatars/edit-thread-avatar.react.js
33 ↗(On Diff #33274)

Good catch fixing this

35 ↗(On Diff #33274)

I don't understand why this type needs to include MinimallyEncodedResolvedThreadInfo when it didn't previously include ResolvedThreadInfo

This revision is now accepted and ready to land.Nov 15 2023, 12:34 PM

address feedback and land

This revision was landed with ongoing or failed builds.Nov 16 2023, 11:23 AM
This revision was automatically updated to reflect the committed changes.