Paths

Table of Contentst

Differential D9896

[lib] Introduce `MinimallyEncodedResolvedThreadInfo` and start refactoring
ClosedPublic
Actions

Authored by atul on Nov 15 2023, 10:06 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 2, 12:18 AM

	Unknown Object (File)
	Fri, Nov 29, 8:20 PM

	Unknown Object (File)
	Fri, Nov 29, 6:00 PM

	Unknown Object (File)
	Nov 26 2024, 12:00 PM

	Unknown Object (File)
	Oct 26 2024, 1:02 AM

	Unknown Object (File)
	Oct 26 2024, 1:02 AM

	Unknown Object (File)
	Oct 26 2024, 1:02 AM

	Unknown Object (File)
	Oct 26 2024, 1:01 AM

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMM97e284e00f49: [lib] Introduce `MinimallyEncodedResolvedThreadInfo` and start refactoring

Summary

We introduce MinimallyEncodedResolvedThreadInfo and start refactoring to accomodate the type everywhere that ResolvedThreadInfo is.

This diff handles a lot of the "simple stuff." The trickier stuff, specifically w/ useResolvedThread* hooks will be resolved in subsequent diffs.

Depends on D9895

Test Plan

Trusting flow here.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 15 2023, 10:06 AM

atul published this revision for review.Nov 15 2023, 10:07 AM

Harbormaster completed remote builds in B24160: Diff 33274.Nov 15 2023, 10:25 AM

I think there's a mistake here – see my inline comment. Please make sure to remove that change before landing (or if there's some good reason for it, can you re-request review)?

native/avatars/edit-thread-avatar.react.js
33 ↗	(On Diff #33274)	Good catch fixing this
35 ↗	(On Diff #33274)	I don't understand why this type needs to include `MinimallyEncodedResolvedThreadInfo` when it didn't previously include `ResolvedThreadInfo`

This revision is now accepted and ready to land.Nov 15 2023, 12:34 PM

atul added a child revision: D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.Nov 15 2023, 1:49 PM

address feedback and land

This revision was landed with ongoing or failed builds.Nov 16 2023, 11:23 AM

Closed by commit rCOMM97e284e00f49: [lib] Introduce `MinimallyEncodedResolvedThreadInfo` and start refactoring (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM97e284e00f49: [lib] Introduce `MinimallyEncodedResolvedThreadInfo` and start refactoring.

Harbormaster failed remote builds in B24221: Diff 33356!Nov 16 2023, 11:52 AM

Revision Contents
Changeset List

Path

Size

lib/

components/

chat-mention-provider.react.js

7 lines

permissions/

minimally-encoded-thread-permissions-validators.js

8 lines

shared/

7 lines

mention-utils.js

7 lines

types/

filter-types.js

3 lines

minimally-encoded-thread-permissions-types.js

5 lines

thread-types.js

5 lines

native/

avatars/

edit-thread-avatar.react.js

7 lines

thread-avatar.react.js

4 lines

chat/

settings/

delete-thread.react.js

8 lines

thread-settings-avatar.react.js

3 lines

thread-settings-delete-thread.react.js

3 lines

thread-settings-name.react.js

3 lines

thread-settings.react.js

23 lines

components/

thread-list-thread.react.js

3 lines

web/

calendar/

3 lines

markdown/

markdown-chat-mention.react.js

3 lines

modals/

history/

history-entry.react.js

3 lines

Diff 33357

lib/components/chat-mention-provider.react.js

Loading...

lib/permissions/minimally-encoded-thread-permissions-validators.js

Loading...

lib/shared/markdown.js

Loading...

lib/shared/mention-utils.js

Loading...

lib/types/filter-types.js

Loading...

lib/types/minimally-encoded-thread-permissions-types.js

Loading...

lib/types/thread-types.js

Loading...

native/avatars/edit-thread-avatar.react.js

Loading...

native/avatars/thread-avatar.react.js

Loading...

native/chat/settings/delete-thread.react.js

Loading...

native/chat/settings/thread-settings-avatar.react.js

Loading...

native/chat/settings/thread-settings-delete-thread.react.js

Loading...

native/chat/settings/thread-settings-name.react.js

Loading...

native/chat/settings/thread-settings.react.js

Loading...

native/components/thread-list-thread.react.js

Loading...

web/calendar/entry.react.js

Loading...

web/markdown/markdown-chat-mention.react.js

Loading...

web/modals/history/history-entry.react.js

Loading...