Page MenuHomePhabricator

[native] update baseNoDataAfterPolicyAcknowledgmentSelector check
ClosedPublic

Authored by kamil on Nov 23 2023, 3:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 6:14 PM
Unknown Object (File)
Wed, Oct 30, 8:50 PM
Unknown Object (File)
Oct 25 2024, 3:45 PM
Unknown Object (File)
Oct 6 2024, 4:35 PM
Unknown Object (File)
Oct 2 2024, 4:38 AM
Unknown Object (File)
Oct 2 2024, 4:38 AM
Unknown Object (File)
Oct 2 2024, 4:38 AM
Unknown Object (File)
Oct 2 2024, 4:35 AM
Subscribers

Details

Summary

Discovered while looking at ENG-5883.

This selector was not sufficiently specific; we should not only verify that all policies are accepted but also check if any policy has been accepted. The previous version could inaccurately return a truthy value in cases other than the absence of data following policy acknowledgment.

Note: In most standard use cases, userPolicies is empty. It's only populated when policies need to be accepted with falsy flags, and right after acknowledgment, to handle cases such as this one.

Test Plan
  1. Test policies mechanism
  2. Test policies with socket issues
  3. Make sure in other cases this condition is falsy

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable