Introduce a simple label component (for e.g. displaying member's role). It will be used in the next diff.
Figma:
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1132%3A76670
Details
Details
- Reviewers
tomek • benschac atul - Commits
- rCOMM4ad6a81bd401: [web] Introduce `Label` component
No changes in the app. The component will appear in members modal.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- jacek/label
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Looks good to me! Are there corresponding designs on Figma? I don't remember seeing a label component, but I could be wrong. Would be good to include a link/screenshot in the description if there are designs.
| web/components/label.react.js | ||
|---|---|---|
| 15–28 | I wonder if it would be easier to understand as something like: const {size, color, bg, children} = props;
const labelStyle = React.useMemo(() => {
fontSize: size ?? '12px',
color: color ?? 'var(--label-default-color)`
background: bg ?? 'var(--label-default-bg)'
}, [bg, color, size]);Not suggesting we should make the change.. just curious what you think | |
| web/components/label.react.js | ||
|---|---|---|
| 15–28 | Note that you need parens () around the curly braces in the block {} to directly return an object, eg.: const returnsObject = () => ({ key1: 'one', key2: 'two', }); | |