[server] Make time filter check less brittle in fetchMessageInfos
ClosedPublic
Actions

Authored by ashoat on Mar 14 2022, 12:49 PM.

Details

Reviewers

tomek
atul

Commits

rCOMM444097a49ec7: [server] Make time filter check less brittle in fetchMessageInfos

Summary

This diff is a follow-up to @palys-swm's comment in D3410.

Test Plan

I tested different values of defaultMaxMessageAge such that some threads would return fewer than defaultNumberPerThread, and some threads would return 0
I tested threads that needed a fetchMostRecentMessages, and threads that needed multiple fetchMessagesBeforeCursor to get to the start
I made sure all threads loaded all the way to the start of a thread if I kept scrolling

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/less-brittle-time-filter-conditions

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Mar 14 2022, 12:49 PM

Herald added subscribers: • benschac, • karol, • adrian. · View Herald TranscriptMar 14 2022, 12:49 PM

ashoat mentioned this in D3410: [server] Don't set EXHAUSTIVE when there is a time filter.Mar 14 2022, 12:49 PM

Harbormaster completed remote builds in B7362: Diff 10366.Mar 14 2022, 12:59 PM

ashoat requested review of this revision.Mar 14 2022, 12:59 PM

Looks great! Agree, this is a lot better approach than the simple invariant I proposed in D3410

This revision is now accepted and ready to land.Mar 15 2022, 3:14 AM

Closed by commit rCOMM444097a49ec7: [server] Make time filter check less brittle in fetchMessageInfos (authored by ashoat). · Explain WhyMar 15 2022, 7:47 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM444097a49ec7: [server] Make time filter check less brittle in fetchMessageInfos.

Revision Contents
Changeset List

Path

Size

server/

src/

fetchers/

message-fetchers.js

101 lines

Diff 10366

View Options

server/src/fetchers/message-fetchers.js

Show First 20 Lines • Show All 87 Lines • ▼ Show 20 Lines	const keysWithObjectsWithKeysToBeRedacted = new Set([
'entryInfos',		'entryInfos',
'roles',		'roles',
]);		]);

// eg {"text":"hello world"} => {"text":"z6lgz waac5"}		// eg {"text":"hello world"} => {"text":"z6lgz waac5"}
const keysWithStringsToBeScrambled = new Set(['text', 'robotext']);		const keysWithStringsToBeScrambled = new Set(['text', 'robotext']);

// eg {"uri":"https://comm.app/1234/5678"}		// eg {"uri":"https://comm.app/1234/5678"}
// => {"uri":"https://comm.app/images/background.png"}		// => {"uri":"https://comm.app/images/placeholder.png"}
const keysWithImageURIsToBeReplaced = new Set([		const keysWithImageURIsToBeReplaced = new Set([
'uri',		'uri',
'localURI',		'localURI',
'inputURI',		'inputURI',
'outputURI',		'outputURI',
'newURI',		'newURI',
'thumbnailURI',		'thumbnailURI',
]);		]);
Show All 13 Lines
function generateColorRedactionFn(): string => string {		function generateColorRedactionFn(): string => string {
const salt = Math.random().toString(16);		const salt = Math.random().toString(16);
return (oldColor: string) => {		return (oldColor: string) => {
return `${stringHash(oldColor.concat(salt)).toString(16).slice(0, 6)}`;		return `${stringHash(oldColor.concat(salt)).toString(16).slice(0, 6)}`;
};		};
}		}

function placeholderImageURI(): string {		function placeholderImageURI(): string {
return 'https://comm.app/images/background.png';		return 'https://comm.app/images/placeholder.png';
}		}

function scrambleText(str: string): string {		function scrambleText(str: string): string {
const arr = [];		const arr = [];
for (const char of str) {		for (const char of str) {
if (char === ' ') {		if (char === ' ') {
arr.push(' ');		arr.push(' ');
continue;		continue;
▲ Show 20 Lines • Show All 176 Lines • Show Last 20 Lines

[server] Make time filter check less brittle in fetchMessageInfosClosedPublicActions