Page MenuHomePhabricator
Differential D3445

[web] Remove `div.devices` and associated assets from `Splash` component
ClosedPublic
Actions

Authored by atul on Mar 16 2022, 2:30 PM.
Tags
None
Referenced Files
F2905666: D3445.diff
Sun, Oct 6, 7:24 AM
Unknown Object (File)
Fri, Oct 4, 5:38 PM
Unknown Object (File)
Fri, Oct 4, 9:22 AM
Unknown Object (File)
Tue, Sep 24, 6:14 AM
Unknown Object (File)
Tue, Sep 24, 6:13 AM
Unknown Object (File)
Mon, Sep 23, 4:03 PM
Unknown Object (File)
Wed, Sep 18, 4:22 AM
Unknown Object (File)
Wed, Sep 18, 4:22 AM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
varun
• benschac
• jim
ashoat
Commits
rCOMM6d374b41c7b7: [web] Remove `div.devices` and associated assets from `Splash` component
Summary

Here's what it looks like after:

c1b7.png (1×3 px, 1 MB)

Test Plan

Searched through repo for occurences of "android_screenshot" and "ios_screenshot" and couldn't find any.

Searched through repo for occurences of "css.devices" and ".devices" and couldn't find anywhere else in the codebase where those styles were used.

Made sure removing the div didn't cause any layout issues (though the whole thing is going anyways so it probably doesn't matter).

Diff Detail

Repository
rCOMM Comm
Branch
landmarch16 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 16 2022, 2:30 PM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 16 2022, 2:30 PM
atul published this revision for review.Mar 16 2022, 2:31 PM
atul edited the summary of this revision. (Show Details)Mar 16 2022, 2:34 PM
Harbormaster completed remote builds in B7431: Diff 10461.Mar 16 2022, 2:35 PM
atul added a reviewer: ashoat.Mar 16 2022, 2:36 PM
atul retitled this revision from [web] Cut `div.devices` and associated assets from `Splash` component to [web] Remove `div.devices` and associated assets from `Splash` component.Mar 16 2022, 3:10 PM
atul edited the summary of this revision. (Show Details)Mar 16 2022, 9:10 PM
atul added a parent revision: D3443: [landing] Remove images that are no longer used.
atul added a child revision: D3446: [web] Remove `background.png` from `Splash` and rename to `placeholder.png`.
ashoat accepted this revision.Mar 16 2022, 9:18 PM

Thanks for detailing the testing process. That sort of detailed test plan is super helpful to see, even for simple diffs like this

This revision is now accepted and ready to land.Mar 16 2022, 9:18 PM
atul edited the summary of this revision. (Show Details)Mar 16 2022, 9:31 PM
atul removed a parent revision: D3443: [landing] Remove images that are no longer used.
atul updated this revision to Diff 10471.Mar 16 2022, 9:37 PM
atul edited the summary of this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Mar 16 2022, 9:38 PM
Closed by commit rCOMM6d374b41c7b7: [web] Remove `div.devices` and associated assets from `Splash` component (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM6d374b41c7b7: [web] Remove `div.devices` and associated assets from `Splash` component.
Harbormaster completed remote builds in B7440: Diff 10471.Mar 16 2022, 9:42 PM

Revision Contents
Changeset List

Diff 10471

View Options

server/images/android_screenshot.png

Loading...
View Options

server/images/android_screenshot@2x.png

Loading...
View Options

server/images/ios_screenshot.png

Loading...
View Options

server/images/ios_screenshot@2x.png

Loading...
View Options

web/splash/splash.css

Loading...
View Options

web/splash/splash.react.js

Loading...