Paths

Table of Contentst

[web] Remove `div.content` from `Splash`
ClosedPublic
Actions

Authored by atul on Mar 16 2022, 10:17 PM.

Details

Reviewers

• jacek
tomek
ashoat
varun
• benschac

Commits

rCOMMa755424beee0: [web] Remove `div.content` from `Splash`

Summary

Cut div.content in splash.react.js and associated styles in splash.css.

Here's how it looks:

depends on D3448

Test Plan

Same as D3447 (tldr: make sure we can still log in, etc)

Diff Detail

Repository

rCOMM Comm

Branch

landmarch16 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 16 2022, 10:17 PM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 16 2022, 10:17 PM

atul published this revision for review.Mar 16 2022, 10:17 PM

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B7435: Diff 10465.Mar 16 2022, 10:21 PM

• benschac accepted this revision.Mar 17 2022, 12:25 AM

This revision is now accepted and ready to land.Mar 17 2022, 12:25 AM

atul edited the summary of this revision. (Show Details)Mar 17 2022, 4:11 AM

atul added a parent revision: D3448: [web] Remove `div.bottomContainer` from `Splash`.

atul added a child revision: D3450: [web] Remove everything from `Splash` except Log in button.

ashoat accepted this revision.Mar 17 2022, 4:14 AM

rebase before landing

Harbormaster failed remote builds in B7447: Diff 10486!Mar 17 2022, 6:08 PM

blah

Harbormaster failed remote builds in B7448: Diff 10488!Mar 17 2022, 6:15 PM

This revision was landed with ongoing or failed builds.Mar 17 2022, 6:17 PM

Closed by commit rCOMMa755424beee0: [web] Remove `div.content` from `Splash`. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMa755424beee0: [web] Remove `div.content` from `Splash`.

Revision Contents
Changeset List

Path

Size

web/

splash/

splash.css

33 lines

splash.react.js

16 lines

Diff 10488

View Options

web/splash/splash.css