Page MenuHomePhabricator
Differential D3450

[web] Remove everything from `Splash` except Log in button
ClosedPublic
Actions

Authored by atul on Mar 16 2022, 3:31 PM.
Tags
None
Referenced Files
F6239625: D3450.id10491.diff
Thu, Apr 24, 8:42 PM
F6236768: D3450.diff
Thu, Apr 24, 3:49 PM
Unknown Object (File)
Sat, Apr 19, 6:21 PM
Unknown Object (File)
Fri, Apr 18, 10:06 PM
Unknown Object (File)
Tue, Apr 8, 6:43 AM
Unknown Object (File)
Sun, Mar 30, 4:53 PM
Unknown Object (File)
Mar 10 2025, 2:01 AM
Unknown Object (File)
Mar 10 2025, 2:00 AM
View All Files
Subscribers
• adrian
• karol

Details

Reviewers
• jacek
tomek
• benschac
varun
ashoat
Commits
rCOMMe34d88b6b0d0: [web] Remove everything from `Splash` except Log in button
Summary

Remove everything from Splash except for the "Log in" button.

(Added some placeholder styles that will be shortly removed)

depends on D3449

Test Plan

Same as D3447 (tldr: make sure we can still log in, etc)

Diff Detail

Repository
rCOMM Comm
Branch
landmarch16 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
splash/
27 lines
15 lines

Diff 10490

View Options

web/splash/splash.css

Show First 20 Lines • Show All 390 Lines • ▼ Show 20 Linesbool create_persist_storage_table(sqlite3 *db) {
std::string query = std::string query =
"CREATE TABLE IF NOT EXISTS persist_storage (" "CREATE TABLE IF NOT EXISTS persist_storage ("
" key TEXT UNIQUE PRIMARY KEY NOT NULL," " key TEXT UNIQUE PRIMARY KEY NOT NULL,"
" item TEXT NOT NULL" " item TEXT NOT NULL"
");"; ");";
return create_table(db, query, "persist_storage"); return create_table(db, query, "persist_storage");
} }
bool recreate_message_store_threads_table(sqlite3 *db) {
char *errMsg = 0;
// 1. Create table without `last_navigated_to` or `last_pruned`.
std::string create_new_table_query =
"CREATE TABLE IF NOT EXISTS temp_message_store_threads ("
" id TEXT UNIQUE PRIMARY KEY NOT NULL,"
" start_reached INTEGER NOT NULL"
");";
if (sqlite3_exec(db, create_new_table_query.c_str(), NULL, NULL, &errMsg) !=
SQLITE_OK) {
Logger::log(
"Error creating temp_message_store_threads: " + std::string{errMsg});
sqlite3_free(errMsg);
return false;
}
// 2. Dump data from existing `message_store_threads` table into temp table.
std::string copy_data_query =
"INSERT INTO temp_message_store_threads (id, start_reached)"
"SELECT id, start_reached FROM message_store_threads;";
if (sqlite3_exec(db, copy_data_query.c_str(), NULL, NULL, &errMsg) !=
SQLITE_OK) {
Logger::log(
"Error dumping data from existing message_store_threads to "
"temp_message_store_threads: " +
std::string{errMsg});
sqlite3_free(errMsg);
return false;
}
// 3. Drop the existing `message_store_threads` table.
std::string drop_old_table_query = "DROP TABLE message_store_threads;";
if (sqlite3_exec(db, drop_old_table_query.c_str(), NULL, NULL, &errMsg) !=
SQLITE_OK) {
Logger::log(
"Error dropping message_store_threads table: " + std::string{errMsg});
sqlite3_free(errMsg);
return false;
}
// 4. Rename the temp table back to `message_store_threads`.
std::string rename_table_query =
"ALTER TABLE temp_message_store_threads RENAME TO message_store_threads;";
if (sqlite3_exec(db, rename_table_query.c_str(), NULL, NULL, &errMsg) !=
SQLITE_OK) {
Logger::log(
"Error renaming temp_message_store_threads to message_store_threads: " +
std::string{errMsg});
sqlite3_free(errMsg);
return false;
}
return true;
}
bool create_schema(sqlite3 *db) { bool create_schema(sqlite3 *db) {
char *error; char *error;
sqlite3_exec( sqlite3_exec(
db, db,
"CREATE TABLE IF NOT EXISTS drafts (" "CREATE TABLE IF NOT EXISTS drafts ("
" key TEXT UNIQUE PRIMARY KEY NOT NULL," " key TEXT UNIQUE PRIMARY KEY NOT NULL,"
" text TEXT NOT NULL" " text TEXT NOT NULL"
");" ");"
▲ Show 20 Lines • Show All 49 Lines • ▼ Show 20 Lines sqlite3_exec(
"CREATE TABLE IF NOT EXISTS metadata (" "CREATE TABLE IF NOT EXISTS metadata ("
" name TEXT UNIQUE PRIMARY KEY NOT NULL," " name TEXT UNIQUE PRIMARY KEY NOT NULL,"
" data TEXT NOT NULL" " data TEXT NOT NULL"
");" ");"
"CREATE TABLE IF NOT EXISTS message_store_threads (" "CREATE TABLE IF NOT EXISTS message_store_threads ("
" id TEXT UNIQUE PRIMARY KEY NOT NULL," " id TEXT UNIQUE PRIMARY KEY NOT NULL,"
" start_reached INTEGER NOT NULL," " start_reached INTEGER NOT NULL"
" last_navigated_to BIGINT NOT NULL,"
" last_pruned BIGINT NOT NULL"
");" ");"
"CREATE TABLE IF NOT EXISTS reports (" "CREATE TABLE IF NOT EXISTS reports ("
" id TEXT UNIQUE PRIMARY KEY NOT NULL," " id TEXT UNIQUE PRIMARY KEY NOT NULL,"
" report TEXT NOT NULL" " report TEXT NOT NULL"
");" ");"
"CREATE TABLE IF NOT EXISTS persist_storage (" "CREATE TABLE IF NOT EXISTS persist_storage ("
▲ Show 20 Lines • Show All 235 Lines • ▼ Show 20 Linesstd::vector<std::pair<unsigned int, SQLiteMigration>> migrations{
{22, {enable_write_ahead_logging_mode, false}}, {22, {enable_write_ahead_logging_mode, false}},
{23, {create_metadata_table, true}}, {23, {create_metadata_table, true}},
{24, {add_not_null_constraint_to_drafts, true}}, {24, {add_not_null_constraint_to_drafts, true}},
{25, {add_not_null_constraint_to_metadata, true}}, {25, {add_not_null_constraint_to_metadata, true}},
{26, {add_avatar_column_to_threads_table, true}}, {26, {add_avatar_column_to_threads_table, true}},
{27, {add_pinned_count_column_to_threads, true}}, {27, {add_pinned_count_column_to_threads, true}},
{28, {create_message_store_threads_table, true}}, {28, {create_message_store_threads_table, true}},
{29, {create_reports_table, true}}, {29, {create_reports_table, true}},
{30, {create_persist_storage_table, true}}}}; {30, {create_persist_storage_table, true}},
{31, {recreate_message_store_threads_table, true}}}};
enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED }; enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED };
MigrationResult applyMigrationWithTransaction( MigrationResult applyMigrationWithTransaction(
sqlite3 *db, sqlite3 *db,
const MigrateFunction &migrate, const MigrateFunction &migrate,
int index) { int index) {
sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr); sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr);
▲ Show 20 Lines • Show All 185 Lines • ▼ Show 20 Lines static auto storage = make_storage(
make_column("pinned_count", &Thread::pinned_count, default_value(0))), make_column("pinned_count", &Thread::pinned_count, default_value(0))),
make_table( make_table(
"metadata", "metadata",
make_column("name", &Metadata::name, unique(), primary_key()), make_column("name", &Metadata::name, unique(), primary_key()),
make_column("data", &Metadata::data)), make_column("data", &Metadata::data)),
make_table( make_table(
"message_store_threads", "message_store_threads",
make_column("id", &MessageStoreThread::id, unique(), primary_key()), make_column("id", &MessageStoreThread::id, unique(), primary_key()),
make_column("start_reached", &MessageStoreThread::start_reached), make_column("start_reached", &MessageStoreThread::start_reached)),
make_column(
"last_navigated_to", &MessageStoreThread::last_navigated_to),
make_column("last_pruned", &MessageStoreThread::last_pruned)),
make_table( make_table(
"reports", "reports",
make_column("id", &Report::id, unique(), primary_key()), make_column("id", &Report::id, unique(), primary_key()),
make_column("report", &Report::report)), make_column("report", &Report::report)),
make_table( make_table(
"persist_storage", "persist_storage",
make_column("key", &PersistItem::key, unique(), primary_key()), make_column("key", &PersistItem::key, unique(), primary_key()),
make_column("item", &PersistItem::item)) make_column("item", &PersistItem::item))
▲ Show 20 Lines • Show All 380 Lines • Show Last 20 Lines
View Options

web/splash/splash.react.js

Show First 20 Lines • Show All 390 Lines • ▼ Show 20 Linesbool create_persist_storage_table(sqlite3 *db) {
std::string query = std::string query =
"CREATE TABLE IF NOT EXISTS persist_storage (" "CREATE TABLE IF NOT EXISTS persist_storage ("
" key TEXT UNIQUE PRIMARY KEY NOT NULL," " key TEXT UNIQUE PRIMARY KEY NOT NULL,"
" item TEXT NOT NULL" " item TEXT NOT NULL"
");"; ");";
return create_table(db, query, "persist_storage"); return create_table(db, query, "persist_storage");
} }
bool recreate_message_store_threads_table(sqlite3 *db) {
char *errMsg = 0;
// 1. Create table without `last_navigated_to` or `last_pruned`.
std::string create_new_table_query =
"CREATE TABLE IF NOT EXISTS temp_message_store_threads ("
" id TEXT UNIQUE PRIMARY KEY NOT NULL,"
" start_reached INTEGER NOT NULL"
");";
if (sqlite3_exec(db, create_new_table_query.c_str(), NULL, NULL, &errMsg) !=
SQLITE_OK) {
Logger::log(
"Error creating temp_message_store_threads: " + std::string{errMsg});
sqlite3_free(errMsg);
return false;
}
// 2. Dump data from existing `message_store_threads` table into temp table.
std::string copy_data_query =
"INSERT INTO temp_message_store_threads (id, start_reached)"
"SELECT id, start_reached FROM message_store_threads;";
if (sqlite3_exec(db, copy_data_query.c_str(), NULL, NULL, &errMsg) !=
SQLITE_OK) {
Logger::log(
"Error dumping data from existing message_store_threads to "
"temp_message_store_threads: " +
std::string{errMsg});
sqlite3_free(errMsg);
return false;
}
// 3. Drop the existing `message_store_threads` table.
std::string drop_old_table_query = "DROP TABLE message_store_threads;";
if (sqlite3_exec(db, drop_old_table_query.c_str(), NULL, NULL, &errMsg) !=
SQLITE_OK) {
Logger::log(
"Error dropping message_store_threads table: " + std::string{errMsg});
sqlite3_free(errMsg);
return false;
}
// 4. Rename the temp table back to `message_store_threads`.
std::string rename_table_query =
"ALTER TABLE temp_message_store_threads RENAME TO message_store_threads;";
if (sqlite3_exec(db, rename_table_query.c_str(), NULL, NULL, &errMsg) !=
SQLITE_OK) {
Logger::log(
"Error renaming temp_message_store_threads to message_store_threads: " +
std::string{errMsg});
sqlite3_free(errMsg);
return false;
}
return true;
}
bool create_schema(sqlite3 *db) { bool create_schema(sqlite3 *db) {
char *error; char *error;
sqlite3_exec( sqlite3_exec(
db, db,
"CREATE TABLE IF NOT EXISTS drafts (" "CREATE TABLE IF NOT EXISTS drafts ("
" key TEXT UNIQUE PRIMARY KEY NOT NULL," " key TEXT UNIQUE PRIMARY KEY NOT NULL,"
" text TEXT NOT NULL" " text TEXT NOT NULL"
");" ");"
▲ Show 20 Lines • Show All 49 Lines • ▼ Show 20 Lines sqlite3_exec(
"CREATE TABLE IF NOT EXISTS metadata (" "CREATE TABLE IF NOT EXISTS metadata ("
" name TEXT UNIQUE PRIMARY KEY NOT NULL," " name TEXT UNIQUE PRIMARY KEY NOT NULL,"
" data TEXT NOT NULL" " data TEXT NOT NULL"
");" ");"
"CREATE TABLE IF NOT EXISTS message_store_threads (" "CREATE TABLE IF NOT EXISTS message_store_threads ("
" id TEXT UNIQUE PRIMARY KEY NOT NULL," " id TEXT UNIQUE PRIMARY KEY NOT NULL,"
" start_reached INTEGER NOT NULL," " start_reached INTEGER NOT NULL"
" last_navigated_to BIGINT NOT NULL,"
" last_pruned BIGINT NOT NULL"
");" ");"
"CREATE TABLE IF NOT EXISTS reports (" "CREATE TABLE IF NOT EXISTS reports ("
" id TEXT UNIQUE PRIMARY KEY NOT NULL," " id TEXT UNIQUE PRIMARY KEY NOT NULL,"
" report TEXT NOT NULL" " report TEXT NOT NULL"
");" ");"
"CREATE TABLE IF NOT EXISTS persist_storage (" "CREATE TABLE IF NOT EXISTS persist_storage ("
▲ Show 20 Lines • Show All 235 Lines • ▼ Show 20 Linesstd::vector<std::pair<unsigned int, SQLiteMigration>> migrations{
{22, {enable_write_ahead_logging_mode, false}}, {22, {enable_write_ahead_logging_mode, false}},
{23, {create_metadata_table, true}}, {23, {create_metadata_table, true}},
{24, {add_not_null_constraint_to_drafts, true}}, {24, {add_not_null_constraint_to_drafts, true}},
{25, {add_not_null_constraint_to_metadata, true}}, {25, {add_not_null_constraint_to_metadata, true}},
{26, {add_avatar_column_to_threads_table, true}}, {26, {add_avatar_column_to_threads_table, true}},
{27, {add_pinned_count_column_to_threads, true}}, {27, {add_pinned_count_column_to_threads, true}},
{28, {create_message_store_threads_table, true}}, {28, {create_message_store_threads_table, true}},
{29, {create_reports_table, true}}, {29, {create_reports_table, true}},
{30, {create_persist_storage_table, true}}}}; {30, {create_persist_storage_table, true}},
{31, {recreate_message_store_threads_table, true}}}};
enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED }; enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED };
MigrationResult applyMigrationWithTransaction( MigrationResult applyMigrationWithTransaction(
sqlite3 *db, sqlite3 *db,
const MigrateFunction &migrate, const MigrateFunction &migrate,
int index) { int index) {
sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr); sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr);
▲ Show 20 Lines • Show All 185 Lines • ▼ Show 20 Lines static auto storage = make_storage(
make_column("pinned_count", &Thread::pinned_count, default_value(0))), make_column("pinned_count", &Thread::pinned_count, default_value(0))),
make_table( make_table(
"metadata", "metadata",
make_column("name", &Metadata::name, unique(), primary_key()), make_column("name", &Metadata::name, unique(), primary_key()),
make_column("data", &Metadata::data)), make_column("data", &Metadata::data)),
make_table( make_table(
"message_store_threads", "message_store_threads",
make_column("id", &MessageStoreThread::id, unique(), primary_key()), make_column("id", &MessageStoreThread::id, unique(), primary_key()),
make_column("start_reached", &MessageStoreThread::start_reached), make_column("start_reached", &MessageStoreThread::start_reached)),
make_column(
"last_navigated_to", &MessageStoreThread::last_navigated_to),
make_column("last_pruned", &MessageStoreThread::last_pruned)),
make_table( make_table(
"reports", "reports",
make_column("id", &Report::id, unique(), primary_key()), make_column("id", &Report::id, unique(), primary_key()),
make_column("report", &Report::report)), make_column("report", &Report::report)),
make_table( make_table(
"persist_storage", "persist_storage",
make_column("key", &PersistItem::key, unique(), primary_key()), make_column("key", &PersistItem::key, unique(), primary_key()),
make_column("item", &PersistItem::item)) make_column("item", &PersistItem::item))
▲ Show 20 Lines • Show All 380 Lines • Show Last 20 Lines