Details

Reviewers

tomek
• karol
varun

Commits

rCOMMfb186959aef0: [services] Tunnelbroker - Validate sessionID and deviceID in database entities.

Summary

Validating sessionID and deviceID fields in database item entities using validation functions in Tools.

Note:
Validating empty strings are moved to D3525 which will be merged.

Related linear task: ENG-618

Test Plan

Successfully built and run service using yarn run-tunnelbroker-service.

Diff Detail

Repository

rCOMM Comm

Branch

deviceid-session-validation

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• max created this revision.Mar 28 2022, 6:47 AM

Herald added subscribers: • benschac, • karol, atul and 3 others. · View Herald TranscriptMar 28 2022, 6:47 AM

• max edited the summary of this revision. (Show Details)Mar 28 2022, 6:50 AM

• max added reviewers: tomek, • karol, varun.

Harbormaster completed remote builds in B7646: Diff 10740.Mar 28 2022, 6:57 AM

• max requested review of this revision.Mar 28 2022, 6:57 AM

If this diff has a dependency on D3525, please specify it! You can do this by hitting "Edit Related Revisions..." in the UI on this page, or you can do it by specifying "Depends on Dsomething" in the diff description when creating the diff with arc diff.

(Apologies if there is no dependency, I may be misunderstanding your diff description.)

tomek requested changes to this revision.Mar 29 2022, 5:51 AM

tomek added inline comments.

services/tunnelbroker/src/Database/MessageItem.cpp
36–47	Shouldn't we keep checking `messageID` and `expire`?

This revision now requires changes to proceed.Mar 29 2022, 5:51 AM

• max planned changes to this revision.Mar 30 2022, 4:24 AM

Moving it on top of D3525 to be more clear.

• max added a parent revision: D3525: [services] Tunnelbroker - Empty field checks in database items.Mar 31 2022, 6:07 AM

• max marked an inline comment as done.

• max added inline comments.

services/tunnelbroker/src/Database/MessageItem.cpp
36–47	Shouldn't we keep checking `messageID` and `expire`? Right, but it's on the other diff. Moved it on top of the D3525 to be more clear.

Harbormaster completed remote builds in B7761: Diff 10877.Mar 31 2022, 6:13 AM

• max mentioned this in D3525: [services] Tunnelbroker - Empty field checks in database items.Mar 31 2022, 6:16 AM

In D3526#96388, @ashoat wrote:

If this diff has a dependency on D3525, please specify it! You can do this by hitting "Edit Related Revisions..." in the UI on this page, or you can do it by specifying "Depends on Dsomething" in the diff description when creating the diff with arc diff.

(Apologies if there is no dependency, I may be misunderstanding your diff description.)

It was like two separate parallel diffs that will be merged. But I'm changing to Parent-Child diffs stack right now to be more clear.
Thanks!

tomek accepted this revision.Mar 31 2022, 8:43 AM

This revision is now accepted and ready to land.Mar 31 2022, 8:43 AM

Rebasing on master. Merging changes.

Harbormaster completed remote builds in B7954: Diff 11148.Apr 7 2022, 2:48 AM

Rebase on master.

This revision was landed with ongoing or failed builds.Apr 7 2022, 2:51 AM

Closed by commit rCOMMfb186959aef0: [services] Tunnelbroker - Validate sessionID and deviceID in database entities. (authored by • max). · Explain Why

This revision was automatically updated to reflect the committed changes.

• max added a commit: rCOMMfb186959aef0: [services] Tunnelbroker - Validate sessionID and deviceID in database entities..

Harbormaster completed remote builds in B7955: Diff 11158.Apr 7 2022, 2:57 AM