Page MenuHomePhabricator

[server] Add baseRoutePath to app URL config JSON
ClosedPublic

Authored by ashoat on Mar 29 2022, 3:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 6:54 PM
Unknown Object (File)
Wed, Nov 27, 6:33 PM
Unknown Object (File)
Wed, Nov 27, 4:42 PM
Unknown Object (File)
Tue, Nov 12, 4:10 AM
Unknown Object (File)
Sun, Nov 10, 12:11 AM
Unknown Object (File)
Sun, Nov 10, 12:11 AM
Unknown Object (File)
Sun, Nov 10, 12:03 AM
Unknown Object (File)
Fri, Nov 8, 10:40 PM

Details

Summary

Just basePath (external) isn't enough – to properly detect what external URL triggered the request, we need to check if the internal URL starts with a particular baseRoutePath. We also need this in order to find/replace the internal URL so we can get the external URL.

Test Plan

This diff was tested in combination with the following diffs. On its own, it just changes a type

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage