Page MenuHomePhabricator
Differential D3563

Remove 'Need notif permissions' alert from iOS since apple revievers requested to do so
ClosedPublic
Actions

Authored by marcin on Mar 30 2022, 7:06 AM.
Tags
None
Referenced Files
F3378893: D3563.id12418.diff
Wed, Nov 27, 1:48 PM
F3378860: D3563.id12202.diff
Wed, Nov 27, 1:37 PM
F3378851: D3563.id11978.diff
Wed, Nov 27, 1:34 PM
F3378597: D3563.diff
Wed, Nov 27, 11:47 AM
Unknown Object (File)
Sun, Nov 10, 5:59 AM
Unknown Object (File)
Sun, Nov 10, 5:59 AM
Unknown Object (File)
Sun, Nov 10, 5:59 AM
Unknown Object (File)
Sun, Nov 10, 5:59 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac

Details

Reviewers
tomek
• jacek
ashoat
Commits
rCOMM78ac79facc06: Remove 'Need notif permissions' alert from iOS since apple revievers requested…
Summary

This differential stops showing "Need notif permissions" alert on iOS but leaves it for android. This change was requested by apple reviewers.

Test Plan

Build app, disable notifications both at the beggining and later in settings and check that alert does not appear in iOS.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Mar 30 2022, 7:06 AM
Herald added subscribers: • abosh, • benschac, • karol and 3 others. · View Herald TranscriptMar 30 2022, 7:06 AM
Harbormaster completed remote builds in B7714: Diff 10816.Mar 30 2022, 7:12 AM
marcin requested review of this revision.Mar 30 2022, 7:12 AM
marcin added a child revision: D3564: Set deviceToken to null upon notification permissions acquisition failure.Mar 30 2022, 7:24 AM
ashoat accepted this revision.Mar 30 2022, 10:41 PM
This revision is now accepted and ready to land.Mar 30 2022, 10:41 PM
marcin updated this revision to Diff 11001.Apr 4 2022, 7:23 AM

Rebase after introducing D3608

marcin added a parent revision: D3608: Android bugfix: call failedToRegisterPushPermission of PushHandler if notifications are disabled.Apr 4 2022, 7:25 AM
Harbormaster completed remote builds in B7833: Diff 11001.Apr 4 2022, 12:04 PM
marcin updated this revision to Diff 11340.Apr 12 2022, 4:14 AM

Rebase

Harbormaster completed remote builds in B8113: Diff 11340.Apr 12 2022, 4:21 AM
marcin updated this revision to Diff 11978.Apr 27 2022, 5:22 AM

Rebase

Harbormaster completed remote builds in B8594: Diff 11978.Apr 27 2022, 5:30 AM
marcin updated this revision to Diff 12202.May 4 2022, 5:09 AM

Rebase

Harbormaster completed remote builds in B8756: Diff 12202.May 4 2022, 6:29 AM
marcin updated this revision to Diff 12344.May 6 2022, 3:35 AM

Rebase

Harbormaster completed remote builds in B8849: Diff 12344.May 6 2022, 3:41 AM
• karol removed a subscriber: • karol.May 6 2022, 3:56 AM
marcin updated this revision to Diff 12418.May 9 2022, 5:24 AM

Rebase

Harbormaster completed remote builds in B8913: Diff 12418.May 9 2022, 5:30 AM
Closed by commit rCOMM78ac79facc06: Remove 'Need notif permissions' alert from iOS since apple revievers requested… (authored by marcin). · Explain WhyMay 9 2022, 5:50 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM78ac79facc06: Remove 'Need notif permissions' alert from iOS since apple revievers requested….

Revision Contents
Changeset List

PathSize
native/
push/
35 lines

Diff 10816

View Options

native/push/push-handler.react.js

Loading...