Paths

Table of Contentst

-
web/chat/
-
chat/
-
chat-message-list.css
-
message-timestamp-tooltip.react.js

[web] Remove `MessageTimestampTooltip` component and associated styles
ClosedPublic
Actions

Authored by atul on Mar 30 2022, 11:25 AM.

Details

Reviewers

ashoat
• jacek
tomek
• benschac

Commits

rCOMM98dd5adf8fb0: [web] Remove `MessageTimestampTooltip` component and associated styles

Summary

Remove the MessageTimestampTooltip which we will no longer need once we incorporate message timestamp into the MessageActionButtons component.

Next diff:

Display timestamp as part of MessageActionButtons component.

Depends on D3567

Test Plan

flow? all usages of component were removed in the previous diff

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 30 2022, 11:25 AM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMar 30 2022, 11:25 AM

atul added inline comments.Mar 30 2022, 11:29 AM

web/chat/chat-message-list.css
54	Searched `messageLeftTooltip` in codebase and found no relevant occurrences.
59	Searched `messageRightTooltip` in codebase and found no relevant occurrences.
64	Searched `messageTopLeftTooltip` in codebase and found no occurrences.
69	Searched `messageTopRightTooltip` in codebase and found no occurrences.
74	Searched `messageBottomLeftTooltip` in codebase and found no occurrences.
79	Searched `messageBottomRightTooltip` in codebase and found no occurrences.

atul published this revision for review.Mar 30 2022, 11:29 AM

Harbormaster completed remote builds in B7727: Diff 10841.Mar 30 2022, 11:32 AM

atul added a child revision: D3571: [web] Add message timestamp to `MessageActionButtons` component.Mar 30 2022, 11:55 AM

ashoat accepted this revision.Mar 30 2022, 11:09 PM

This revision is now accepted and ready to land.Mar 30 2022, 11:09 PM

rebase before landing

This revision was landed with ongoing or failed builds.Mar 31 2022, 9:35 AM

Closed by commit rCOMM98dd5adf8fb0: [web] Remove `MessageTimestampTooltip` component and associated styles (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM98dd5adf8fb0: [web] Remove `MessageTimestampTooltip` component and associated styles.

Harbormaster completed remote builds in B7774: Diff 10905.Mar 31 2022, 9:44 AM

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-message-list.css

30 lines

message-timestamp-tooltip.react.js

Diff 10841

View Options

web/chat/chat-message-list.css

Show All 20 Lines
import {		import {
useServerCall,		useServerCall,
useDispatchActionPromise,		useDispatchActionPromise,
} from 'lib/utils/action-utils';		} from 'lib/utils/action-utils';

import MenuItem from '../components/menu-item.react';		import MenuItem from '../components/menu-item.react';
import Menu from '../components/menu.react';		import Menu from '../components/menu.react';
import SidebarListModal from '../modals/chat/sidebar-list-modal.react';		import SidebarListModal from '../modals/chat/sidebar-list-modal.react';
		import SidebarPromoteModal from '../modals/chat/sidebar-promote-modal.react';
import { useModalContext } from '../modals/modal-provider.react';		import { useModalContext } from '../modals/modal-provider.react';
import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';		import ConfirmLeaveThreadModal from '../modals/threads/confirm-leave-thread-modal.react';
import ThreadMembersModal from '../modals/threads/members/members-modal.react';		import ThreadMembersModal from '../modals/threads/members/members-modal.react';
import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';		import SubchannelsModal from '../modals/threads/subchannels/subchannels-modal.react';
import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';		import ThreadSettingsModal from '../modals/threads/thread-settings-modal.react';
import { useSelector } from '../redux/redux-utils';		import { useSelector } from '../redux/redux-utils';
import SWMansionIcon from '../SWMansionIcon.react';		import SWMansionIcon from '../SWMansionIcon.react';
import css from './thread-menu.css';		import css from './thread-menu.css';
▲ Show 20 Lines • Show All 154 Lines • ▼ Show 20 Lines	return (
text="Leave Thread"		text="Leave Thread"
icon="logout"		icon="logout"
dangerous		dangerous
onClick={onClickLeaveThread}		onClick={onClickLeaveThread}
/>		/>
);		);
}, [onClickLeaveThread, threadInfo]);		}, [onClickLeaveThread, threadInfo]);

		const onClickPromoteSidebarToThread = React.useCallback(
		() =>
		pushModal(
		<SidebarPromoteModal
		threadInfo={threadInfo}
		onClose={popModal}
		onConfirm={onPromoteSidebar}
		/>,
		),
		[pushModal, threadInfo, popModal, onPromoteSidebar],
		);

const promoteSidebar = React.useMemo(() => {		const promoteSidebar = React.useMemo(() => {
return (		return (
<MenuItem		<MenuItem
key="promote"		key="promote"
text="Promote Thread"		text="Promote Thread"
icon="message-square-lines"		icon="message-square-lines"
onClick={onPromoteSidebar}		onClick={onClickPromoteSidebarToThread}
/>		/>
);		);
}, [onPromoteSidebar]);		}, [onClickPromoteSidebarToThread]);

const menuItems = React.useMemo(() => {		const menuItems = React.useMemo(() => {
const notificationsItem = (		const notificationsItem = (
<MenuItem key="notifications" text="Notifications" icon="bell" />		<MenuItem key="notifications" text="Notifications" icon="bell" />
);		);
const separator = <hr key="separator" className={css.separator} />;		const separator = <hr key="separator" className={css.separator} />;

// TODO: Enable menu items when the modals are implemented		// TODO: Enable menu items when the modals are implemented
Show All 33 Lines