Page MenuHomePhabricator
Differential D3367

[web] Introduce common `Search` component
ClosedPublic
Actions

Authored by • jacek on Mar 8 2022, 3:57 AM.
Tags
None
Referenced Files
F3293527: D3367.diff
Sat, Nov 16, 5:28 PM
Unknown Object (File)
Fri, Nov 8, 11:02 AM
Unknown Object (File)
Tue, Nov 5, 9:41 PM
Unknown Object (File)
Oct 16 2024, 8:26 AM
Unknown Object (File)
Oct 14 2024, 2:19 AM
Unknown Object (File)
Oct 14 2024, 2:19 AM
Unknown Object (File)
Oct 14 2024, 2:19 AM
Unknown Object (File)
Oct 14 2024, 2:19 AM
View All Files
Subscribers
• adrian
ashoat
atul
• karol

Details

Reviewers
tomek
• benschac
atul
Commits
rCOMMed54b46da22e: [web] Introduce common `Search` component
Summary

As we have design for search for filtering users in modals, the goal is to use the same component for both thread search (for which we don't have design) and thread members search.
This diff moves search logic and styles from thread-list-search into search.
There are no design or behavior changes in this diff - everything should work as before.

Test Plan

Thread search in web app should remain the same

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jacek created this revision.Mar 8 2022, 3:57 AM
Herald added subscribers: • karol, atul, • adrian, ashoat. · View Herald TranscriptMar 8 2022, 3:57 AM
• jacek added reviewers: • benschac, atul.Mar 8 2022, 4:00 AM
Harbormaster completed remote builds in B7207: Diff 10136.Mar 8 2022, 4:02 AM
• jacek requested review of this revision.Mar 8 2022, 4:02 AM
• jacek edited the summary of this revision. (Show Details)Mar 8 2022, 4:23 AM
tomek accepted this revision.Mar 8 2022, 8:56 AM
tomek added inline comments.
web/chat/thread-list-search.react.js
12–22 ↗(On Diff #10136)

This component doesn't seem to do much. Do you think we need it?

This revision is now accepted and ready to land.Mar 8 2022, 8:56 AM
• jacek added a child revision: D3368: [web] Refactor search styling to match Figma.Mar 9 2022, 5:57 AM
• jacek updated this revision to Diff 10343.Mar 14 2022, 9:45 AM

Replaced thread-search-list with search

Harbormaster completed remote builds in B7342: Diff 10343.Mar 14 2022, 9:55 AM
• jacek updated this revision to Diff 10856.Mar 31 2022, 2:21 AM

rebase

Harbormaster completed remote builds in B7740: Diff 10856.Mar 31 2022, 2:32 AM
Closed by commit rCOMMed54b46da22e: [web] Introduce common `Search` component (authored by • jacek). · Explain WhyApr 1 2022, 3:50 AM
This revision was automatically updated to reflect the committed changes.
• jacek added a commit: rCOMMed54b46da22e: [web] Introduce common `Search` component.

Revision Contents
Changeset List

PathSize
web/
chat/
34 lines
8 lines
components/
chat/
2 lines
search.react.js
thread-list-search.react.js
13 lines
components/
33 lines

Diff 10856

View Options

web/chat/chat-thread-list.css

Loading...
View Options

web/chat/chat-thread-list.react.js

Loading...
View Options

web/chat/clear-search-button.react.js

Loading...
View Options

web/chat/thread-list-search.react.js

Loading...
View Options

web/components/clear-search-button.react.js

Loading...
View Options

web/components/search.css

Loading...
View Options

web/components/search.react.js

Loading...