Differential D3676

[web] Introduce friend list modal row
ClosedPublic
Actions

Authored by tomek on Apr 8 2022, 7:25 AM.

Tags

None

Referenced Files

	F3393613: D3676.id11502.diff
	Sat, Nov 30, 3:07 PM

	F3393487: D3676.id11243.diff
	Sat, Nov 30, 2:24 PM

	F3393353: D3676.diff
	Sat, Nov 30, 1:23 PM

	Unknown Object (File)
	Thu, Nov 14, 4:26 AM

	Unknown Object (File)
	Tue, Nov 5, 4:11 AM

	Unknown Object (File)
	Tue, Nov 5, 4:10 AM

	Unknown Object (File)
	Tue, Nov 5, 4:10 AM

	Unknown Object (File)
	Tue, Nov 5, 4:04 AM

Subscribers

Details

Reviewers

• benschac
atul
• jacek

Commits

rCOMM1d3f7f3d5015: [web] Introduce friend list modal row

Summary

This component will be used on friend list to display a row containing username and buttons. https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1274%3A89558 The buttons will be added in next diffs. The avatars may be added later.

Depends on D3675

Test Plan

Display the component in a modal and check if it is rendered correctly.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 8 2022, 7:25 AM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 8 2022, 7:25 AM

tomek added a child revision: D3677: [web] Display friend list buttons in the modal.Apr 8 2022, 7:29 AM

Harbormaster completed remote builds in B8030: Diff 11243.Apr 8 2022, 7:32 AM

tomek requested review of this revision.Apr 8 2022, 7:32 AM

• benschac accepted this revision.Apr 8 2022, 8:14 AM

This revision is now accepted and ready to land.Apr 8 2022, 8:14 AM

Looks good!

(might be helpful to include a screenshot for next time)

In D3676#101050, @atul wrote:

Looks good!

(might be helpful to include a screenshot for next time)

Sorry for not including it here - it was added at the top of the stack but including it earlier would make the review process easier

Closed by commit rCOMM1d3f7f3d5015: [web] Introduce friend list modal row (authored by tomek). · Explain WhyApr 15 2022, 2:16 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM1d3f7f3d5015: [web] Introduce friend list modal row.

Revision Contents
Changeset List

Path

Size

web/

settings/

relationship/

friend-list-row.css

8 lines

friend-list-row.react.js

14 lines

1 line

Diff 11502

web/settings/relationship/friend-list-row.css

Loading...

web/settings/relationship/friend-list-row.react.js

Loading...

web/theme.css

Loading...