add alert to let user know this action can't be undone
https://linear.app/comm/issue/ENG-1016/add-prompt-to-user-that-sidebar-promotion-cant-be-undone
Differential D3755
[native] [feature] [ENG-1016] add alert prompt to user, promote thread cant be undone • benschac on Apr 18 2022, 8:16 AM. Authored by Tags None Referenced Files
Details add alert to let user know this action can't be undone https://linear.app/comm/issue/ENG-1016/add-prompt-to-user-that-sidebar-promotion-cant-be-undone go to promote thread, click cancel, click yes. Functionality should work as expected.
Diff Detail
Event Timeline
Comment Actions
Could you spend a little more time in the future writing your test plans? At this point, this test plan sounds like we should click cancel and then click yes which probably isn't what we wanted. And please start sentences with capital letters.
Comment Actions This should not have been landed, the copy is not clean English... I added a comment to ENG-1016, but to be clear this needs to be fixed ASAP. @palys-swm please never accept a diff with broken English like this. The fact that I flagged it on the task should've been a very strong reason NOT to accept this diff. Or at the very least, to add me to the review! As a result of this, I've added "anything with copy" to the Diff Review Rules that talk about when I need to included in a diff review. Going forward, if you ever see copy in a diff, make sure you add me to the review as a blocking reviewer, and highlight the copy that needs to be reviewed. I would really love to get to a place where I'm not necessary to review English, but apparently we're not there as a team... Comment Actions
Ok, that makes sense. It seems I got a little confused... sorry for that. Going forward, every time a copy changes, will add @ashoat as a blocking reviewer. Comment Actions This is also on me as a native English speaker. For reference, most of the onClick hander was auto-generated with GH autopilot and I didn't take the extra minute to really look at the copy, triple check it, read it out loud. Make sure it was correct. |