Page MenuHomePhabricator

[web] Move `onChangeColor` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic

Authored by atul on Apr 18 2022, 2:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 5:19 AM
Unknown Object (File)
Wed, Oct 23, 8:44 PM
Unknown Object (File)
Fri, Oct 18, 6:09 PM
Unknown Object (File)
Thu, Oct 10, 1:43 AM
Unknown Object (File)
Thu, Oct 10, 1:43 AM
Unknown Object (File)
Thu, Oct 10, 1:43 AM
Unknown Object (File)
Thu, Oct 10, 1:43 AM
Unknown Object (File)
Thu, Oct 10, 1:43 AM

Details

Summary

Move onChangeColor out from inner class component to outer "Connected" functional component.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component.


Depends on D3766

Test Plan
  1. Open ThreadSettingsModal
  2. Change the color a bunch
  3. Log values in onChangeColor to ensure that they continue to be as expected
  4. Hit save after changing the color and ensure that the thread description changed as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Apr 18 2022, 2:56 PM

specifically to turn it into a functional component.

That is helpful to see, can you add that to the diff descriptions of the rest of the elements in your stack?

That is helpful to see, can you add that to the diff descriptions of the rest of the elements in your stack?

Yeah, added it to the four diffs in the stack that were missing that clarification

tomek added inline comments.
web/modals/threads/thread-settings-modal.react.js
447–456
This revision is now accepted and ready to land.Apr 21 2022, 3:08 AM