Page MenuHomePhabricator
Differential D3768

[web] Move `onChangeThreadType` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic
Actions

Authored by atul on Apr 18 2022, 3:04 PM.
Tags
None
Referenced Files
F3353774: D3768.diff
Sat, Nov 23, 11:20 AM
Unknown Object (File)
Sun, Nov 17, 9:53 PM
Unknown Object (File)
Thu, Nov 14, 9:02 AM
Unknown Object (File)
Thu, Nov 14, 9:02 AM
Unknown Object (File)
Sat, Nov 9, 7:39 AM
Unknown Object (File)
Tue, Nov 5, 5:19 AM
Unknown Object (File)
Oct 23 2024, 8:44 PM
Unknown Object (File)
Oct 18 2024, 6:09 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
• jacek
tomek
Commits
rCOMM669e261b8c74: [web] Move `onChangeThreadType` up from `ThreadSettingsModal` to…
Summary

Move onChangeThreadType out from inner class component to outer "Connected" functional component.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component.

Depends on D3767

Test Plan
  1. Open ThreadSettingsModal
  2. Change the thread type
  3. Log values in onChangeThreadtype to ensure that they continue to be as expected
  4. Hit save after changing the color and ensure that the thread description changed as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 18 2022, 3:04 PM
Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 18 2022, 3:04 PM
Harbormaster completed remote builds in B8281: Diff 11577.Apr 18 2022, 3:09 PM
atul requested review of this revision.Apr 18 2022, 3:09 PM
atul added a child revision: D3769: [web] Move `onChangeAccountPassword` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.Apr 18 2022, 3:25 PM
atul updated this revision to Diff 11649.Apr 19 2022, 3:04 PM

rebase

Harbormaster completed remote builds in B8339: Diff 11649.Apr 19 2022, 3:23 PM
tomek accepted this revision.Apr 21 2022, 3:09 AM
tomek added inline comments.
web/modals/threads/thread-settings-modal.react.js
449–459
This revision is now accepted and ready to land.Apr 21 2022, 3:09 AM
atul updated this revision to Diff 11749.Apr 21 2022, 11:06 AM

rebase before addressing feedback

atul updated this revision to Diff 11750.Apr 21 2022, 11:08 AM

address feedback

Harbormaster completed remote builds in B8421: Diff 11749.Apr 21 2022, 11:11 AM
Harbormaster completed remote builds in B8422: Diff 11750.Apr 21 2022, 11:15 AM
Closed by commit rCOMM669e261b8c74: [web] Move `onChangeThreadType` up from `ThreadSettingsModal` to… (authored by atul). · Explain WhyApr 21 2022, 11:15 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM669e261b8c74: [web] Move `onChangeThreadType` up from `ThreadSettingsModal` to….

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
30 lines

Diff 11649

View Options

web/modals/threads/thread-settings-modal.react.js

Loading...