Page MenuHomePhabricator

Improve wording of comments in overlay.nix
AbandonedPublic

Authored by jon on Apr 20 2022, 12:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 1:33 AM
Unknown Object (File)
Tue, Nov 26, 10:08 PM
Unknown Object (File)
Mon, Nov 25, 1:13 PM
Unknown Object (File)
Sat, Nov 23, 9:16 AM
Unknown Object (File)
Sat, Nov 23, 8:52 AM
Unknown Object (File)
Mon, Nov 11, 6:53 AM
Unknown Object (File)
Sun, Nov 10, 1:37 AM
Unknown Object (File)
Thu, Nov 7, 1:42 AM

Details

Reviewers
ashoat
Test Plan

Run nix develop

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This was an accident, meant to update D3274

ashoat requested changes to this revision.Apr 20 2022, 8:09 PM

To your queue to abandon

This revision now requires changes to proceed.Apr 20 2022, 8:09 PM

I don't believe I have the permissions to do so, there's nothing containing "Abandon" on my page.

In D3792#105354, @jonringer-comm wrote:

I don't believe I have the permissions to do so, there's nothing containing "Abandon" on my page.

You should be able to find it in the "Add Action..." dropdown at the bottom of the page:

Screen Shot 2022-04-21 at 12.04.57 PM.png (522×1 px, 151 KB)

This comment was removed by varun.

@jonringer-comm i think you meant to make this fix in https://phabricator.ashoat.com/D3274 . this diff needs to be re-abandoned now i think

ashoat requested changes to this revision.Apr 27 2022, 2:50 PM

To your queue again. The fact that this diff got updated is concerning... it suggests something is messed up in @jonringer-comm local Git. Mastering the Phabricator / Arcanist workflow is crucial to being able to contribute on the team... might be good to do a call with @varun to figure out what's wrong in your local environment and to make sure this doesn't happen again

This revision now requires changes to proceed.Apr 27 2022, 2:50 PM
ashoat requested changes to this revision.Apr 27 2022, 6:18 PM

You're still updating a diff that should've been abandoned!! Please review my previous comment

This revision now requires changes to proceed.Apr 27 2022, 6:18 PM

arc diff defaulted to this :/

I don’t think that’s right. I think you have something going wrong in your Git working copy. You likely have this revision in the commit message of the most recent commit when you run arc diff. You should sync with somebody on the team to get this resolved, and to build a better intuition for why this was happening in the first place and how to avoid it in the future.