Page MenuHomePhabricator
Differential D3794

[web] Move `onDelete` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic
Actions

Authored by atul on Apr 20 2022, 2:18 PM.
Tags
None
Referenced Files
F3197177: D3794.id11678.diff
Sat, Nov 9, 7:37 AM
F3197138: D3794.id11811.diff
Sat, Nov 9, 7:25 AM
F3185281: D3794.diff
Fri, Nov 8, 12:45 PM
Unknown Object (File)
Thu, Nov 7, 4:24 PM
Unknown Object (File)
Tue, Oct 22, 11:15 AM
Unknown Object (File)
Tue, Oct 22, 11:15 AM
Unknown Object (File)
Tue, Oct 22, 11:15 AM
Unknown Object (File)
Tue, Oct 22, 2:05 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
• jacek
tomek
Commits
rCOMMb1102a125a05: [web] Move `onDelete` up from `ThreadSettingsModal` to…
Summary

Move onDelete out from inner class component to outer "Connected" functional component.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component

Depends on D3783

Test Plan
  1. Create delete-able thread
  2. Navigate to ThreadSettingsModal and go to "Delete" tab
  3. Try to delete thread and ensure that it works as expected

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 20 2022, 2:18 PM
Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 20 2022, 2:18 PM
Harbormaster completed remote builds in B8366: Diff 11678.Apr 20 2022, 2:25 PM
atul requested review of this revision.Apr 20 2022, 2:25 PM
atul added a child revision: D3795: [web] Move `changeThreadSettingsAction` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.Apr 20 2022, 2:57 PM
tomek accepted this revision.Apr 21 2022, 3:20 AM
tomek added inline comments.
web/modals/threads/thread-settings-modal.react.js
466

Why do we prevent default here and not in the other places?

This revision is now accepted and ready to land.Apr 21 2022, 3:20 AM
atul added inline comments.Apr 22 2022, 1:43 PM
web/modals/threads/thread-settings-modal.react.js
466

It looks like we do event.preventDefault() for onDelete and onSubmit which are callbacks that are passed to the onClick prop of <Button /> components.

It looks like we don't do event.preventDefault()for the onChange callbacks passed to the <Input /> components.

atul updated this revision to Diff 11811.Apr 22 2022, 1:51 PM

rebase before landing

Harbormaster completed remote builds in B8471: Diff 11811.Apr 22 2022, 1:56 PM
Closed by commit rCOMMb1102a125a05: [web] Move `onDelete` up from `ThreadSettingsModal` to… (authored by atul). · Explain WhyApr 22 2022, 2:01 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb1102a125a05: [web] Move `onDelete` up from `ThreadSettingsModal` to….

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
20 lines

Diff 11678

View Options

web/modals/threads/thread-settings-modal.react.js

Loading...