Page MenuHomePhabricator

[web] Move `onChangeThreadType` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic

Authored by atul on Apr 18 2022, 3:04 PM.
Tags
None
Referenced Files
F3377769: D3768.id11750.diff
Wed, Nov 27, 7:19 AM
Unknown Object (File)
Sat, Nov 23, 2:09 PM
Unknown Object (File)
Sat, Nov 23, 1:53 PM
Unknown Object (File)
Sat, Nov 23, 1:37 PM
Unknown Object (File)
Sat, Nov 23, 11:20 AM
Unknown Object (File)
Sun, Nov 17, 9:53 PM
Unknown Object (File)
Thu, Nov 14, 9:02 AM
Unknown Object (File)
Thu, Nov 14, 9:02 AM

Details

Summary

Move onChangeThreadType out from inner class component to outer "Connected" functional component.

As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component.


Depends on D3767

Test Plan
  1. Open ThreadSettingsModal
  2. Change the thread type
  3. Log values in onChangeThreadtype to ensure that they continue to be as expected
  4. Hit save after changing the color and ensure that the thread description changed as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Apr 18 2022, 3:09 PM
tomek added inline comments.
web/modals/threads/thread-settings-modal.react.js
449–459 ↗(On Diff #11649)
This revision is now accepted and ready to land.Apr 21 2022, 3:09 AM

rebase before addressing feedback