Move onChangeAccountPassword out from inner class component to outer "Connected" functional component.
As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component.
Depends on D3768
Details
Details
- Open ThreadSettingsModal
- Change account password under delete tab
- Log values in onChangeAccountPassword to ensure that the state continues to change as expected
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- actuallylandapril21 (branched from master)
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/modals/threads/thread-settings-modal.react.js | ||
|---|---|---|
| 457–463 ↗ | (On Diff #11650) | When a callback doesn't depend on anything, we can define the function outside the component. But on the other hand, it will break the flow of the code, so it's not necessarily worth it. |
| web/modals/threads/thread-settings-modal.react.js | ||
|---|---|---|
| 457–463 ↗ | (On Diff #11650) | Even though there aren't any dependencies, doesn't using React.useCallback provide referential equality when passed to the inner ThreadSettingsModal class component? |
| web/modals/threads/thread-settings-modal.react.js | ||
|---|---|---|
| 457–463 ↗ | (On Diff #11650) | When a function is defined in global scope, it never changes and is always equal to itself. It's true that callback provide the equality, but it is only needed when a function is redefined, e.g. in render function. |