Move onDelete out from inner class component to outer "Connected" functional component.
As part of the work to refactor ThreadSettingsModal... specifically to turn it into a functional component
Depends on D3783
Details
Details
- Create delete-able thread
- Navigate to ThreadSettingsModal and go to "Delete" tab
- Try to delete thread and ensure that it works as expected
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/modals/threads/thread-settings-modal.react.js | ||
|---|---|---|
| 466 ↗ | (On Diff #11678) | Why do we prevent default here and not in the other places? |
| web/modals/threads/thread-settings-modal.react.js | ||
|---|---|---|
| 466 ↗ | (On Diff #11678) | It looks like we do event.preventDefault() for onDelete and onSubmit which are callbacks that are passed to the onClick prop of <Button /> components. It looks like we don't do event.preventDefault()for the onChange callbacks passed to the <Input /> components. |