Page MenuHomePhabricator
Differential D3821

[web] Temporarily remove refs in `ThreadSettingsModal` altogether
ClosedPublic
Actions

Authored by atul on Apr 24 2022, 11:23 AM.
Tags
None
Referenced Files
F3352653: D3821.id11915.diff
Sat, Nov 23, 6:48 AM
F3352602: D3821.id11826.diff
Sat, Nov 23, 6:33 AM
Unknown Object (File)
Sat, Nov 9, 10:48 PM
Unknown Object (File)
Sat, Nov 9, 2:58 PM
Unknown Object (File)
Sat, Nov 9, 2:55 PM
Unknown Object (File)
Thu, Nov 7, 11:24 PM
Unknown Object (File)
Tue, Nov 5, 5:07 AM
Unknown Object (File)
Sun, Oct 27, 10:24 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol

Details

Reviewers
• jacek
tomek
Commits
rCOMM374213d768ba: [web] Temporarily remove refs in `ThreadSettingsModal` altogether
Summary

The only reason we have the refs is to ref.focus() inputs. That functionality is currently removed and has been replaced by TODO comments.

This diff temporarily removes refs from ThreadSettingsModal and the child "Tab" components. They'll be added back in this stack shortly (eg they'll be brought back to ThreadSettingsModalGeneralTab after state/functionality has been "pushed" down)

Depends on D3764

Test Plan

flow, no changes in functionality since the .focus() lines have already been removed

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 24 2022, 11:23 AM
Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 24 2022, 11:23 AM
atul edited the summary of this revision. (Show Details)Apr 24 2022, 11:24 AM
atul added a parent revision: D3764: [web] Remove usage of `setTab` and replace with `setCurrentTabType`.
Harbormaster completed remote builds in B8479: Diff 11824.Apr 24 2022, 11:27 AM
atul requested review of this revision.Apr 24 2022, 11:27 AM
atul added a child revision: D3822: [web] Lift `mainContent: React.Node` from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.Apr 24 2022, 11:38 AM
atul updated this revision to Diff 11826.Apr 24 2022, 11:43 AM

include removal of instance variables

Harbormaster completed remote builds in B8481: Diff 11826.Apr 24 2022, 11:48 AM
atul added a comment.Apr 25 2022, 6:43 AM

(nameInput added back here: https://phabricator.ashoat.com/D3832)

tomek accepted this revision.Apr 26 2022, 4:46 AM
This revision is now accepted and ready to land.Apr 26 2022, 4:46 AM
atul updated this revision to Diff 11915.Apr 26 2022, 7:40 AM

rebase before landing

Harbormaster completed remote builds in B8549: Diff 11915.Apr 26 2022, 7:46 AM
Closed by commit rCOMM374213d768ba: [web] Temporarily remove refs in `ThreadSettingsModal` altogether (authored by atul). · Explain WhyApr 26 2022, 7:50 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM374213d768ba: [web] Temporarily remove refs in `ThreadSettingsModal` altogether.

Revision Contents
Changeset List

Diff 11824

View Options

web/modals/threads/thread-settings-delete-tab.react.js

Loading...
View Options

web/modals/threads/thread-settings-general-tab.react.js

Loading...
View Options

web/modals/threads/thread-settings-modal.react.js

Loading...