Details

Reviewers

• jacek
tomek

Commits

rCOMMc952321494b1: [web] Turn `ThreadSettingsModal` into functional component

Summary

This diff completely removes the remnants of the ThreadSettingsModal class component. Specifically, this diff lifts the render() function of the class component to the return value of the outer functional component.

Now that we've turned ThreadSettingsModal into a functional component, we're going to continue the refactor by pushing "tab-specific" state/functionality to the ThreadSettings[General/Privacy/Delete]Tab child components (which are also now functional components)

Depends on D3822

Test Plan

Open ThreadSettingsModal
Click around, make some changes, hit save
Make sure that everything continues to look/behave as expected

Diff Detail

Repository

rCOMM Comm

Branch

clean (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Apr 24 2022, 12:54 PM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptApr 24 2022, 12:54 PM

(As of this diff, we've trimmed ThreadSettingsModal from being ~850 lines before refactor => 409 lines... will be even smaller after pushing down state/functionality to the child "tab" components)

atul retitled this revision from [web] Turn `ThreadSettingsModal` into ` functional component to [web] Turn `ThreadSettingsModal` into functional component.Apr 24 2022, 12:57 PM

Harbormaster completed remote builds in B8485: Diff 11830.Apr 24 2022, 12:59 PM

atul requested review of this revision.Apr 24 2022, 12:59 PM

atul added a child revision: D3826: [web] Remove duplicate `thread[Name/Description]Disabled` props in `ThreadSettingsGeneralTab` component.Apr 24 2022, 1:05 PM

In D3825#106086, @atul wrote:

(As of this diff, we've trimmed ThreadSettingsModal from being ~850 lines before refactor => 409 lines... will be even smaller after pushing down state/functionality to the child "tab" components)

Nice!

This revision is now accepted and ready to land.Apr 26 2022, 8:09 AM

atul mentioned this in D3823: [web] Lift `buttons: React.Node` from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.Apr 26 2022, 10:18 AM

rebase

Harbormaster completed remote builds in B8566: Diff 11945.Apr 26 2022, 10:28 AM

atul edited the summary of this revision. (Show Details)Apr 26 2022, 12:25 PM

atul added a parent revision: D3822: [web] Lift `mainContent: React.Node` from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.

rebase

Harbormaster completed remote builds in B8583: Diff 11964.Apr 26 2022, 1:07 PM

rebase before landing

Harbormaster completed remote builds in B8668: Diff 12068.Apr 28 2022, 1:16 PM

Closed by commit rCOMMc952321494b1: [web] Turn `ThreadSettingsModal` into functional component (authored by atul). · Explain WhyApr 28 2022, 1:18 PM